Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] I guess this could end up causing a player to lose an item. If we get a duplicate GUID and we're usi

[DiscordArchive] I guess this could end up causing a player to lose an item. If we get a duplicate GUID and we're usi

[DiscordArchive] I guess this could end up causing a player to lose an item. If we get a duplicate GUID and we're usi

rektbyfaith
Administrator
0
01-29-2025, 04:11 PM
#1
Archived author: walkline • Posted: 2025-01-29T16:11:21.690000+00:00
Original source

I guess this could end up causing a player to lose an item. If we get a duplicate GUID and we're using the REPLACE command for item_instance, the last replace query would overwrite player A item with one belonging to player B, right?
rektbyfaith
01-29-2025, 04:11 PM #1

Archived author: walkline • Posted: 2025-01-29T16:11:21.690000+00:00
Original source

I guess this could end up causing a player to lose an item. If we get a duplicate GUID and we're using the REPLACE command for item_instance, the last replace query would overwrite player A item with one belonging to player B, right?

rektbyfaith
Administrator
0
01-29-2025, 04:16 PM
#2
Archived author: walkline • Posted: 2025-01-29T16:16:49.857000+00:00
Original source

From my understanding, spell related item creation is just one example we're probably creating items all over the place, so fixing this would require a huge refactoring. If we bother to fix it, using atomic operations for item creation would probably be easier, and I don't think it would have a significant impact on performance.
rektbyfaith
01-29-2025, 04:16 PM #2

Archived author: walkline • Posted: 2025-01-29T16:16:49.857000+00:00
Original source

From my understanding, spell related item creation is just one example we're probably creating items all over the place, so fixing this would require a huge refactoring. If we bother to fix it, using atomic operations for item creation would probably be easier, and I don't think it would have a significant impact on performance.

rektbyfaith
Administrator
0
01-29-2025, 04:17 PM
#3
Archived author: Mernhard • Posted: 2025-01-29T16:17:31.466000+00:00
Original source

<@216234897390436353> how fix it?) last build
[Image: IMG_3792.jpg?ex=690c215b&is=690acfdb&hm=...4c077552f&]
rektbyfaith
01-29-2025, 04:17 PM #3

Archived author: Mernhard • Posted: 2025-01-29T16:17:31.466000+00:00
Original source

<@216234897390436353> how fix it?) last build
[Image: IMG_3792.jpg?ex=690c215b&is=690acfdb&hm=...4c077552f&]

rektbyfaith
Administrator
0
01-29-2025, 04:18 PM
#4
Archived author: ModoX • Posted: 2025-01-29T16:18:29.910000+00:00
Original source

eh, sec
rektbyfaith
01-29-2025, 04:18 PM #4

Archived author: ModoX • Posted: 2025-01-29T16:18:29.910000+00:00
Original source

eh, sec

rektbyfaith
Administrator
0
01-29-2025, 04:21 PM
#5
Archived author: Telegrill • Posted: 2025-01-29T16:21:39.571000+00:00
Original source

i mean the other way around is using mutex and lock_guard
rektbyfaith
01-29-2025, 04:21 PM #5

Archived author: Telegrill • Posted: 2025-01-29T16:21:39.571000+00:00
Original source

i mean the other way around is using mutex and lock_guard

rektbyfaith
Administrator
0
01-29-2025, 04:23 PM
#6
Archived author: Telegrill • Posted: 2025-01-29T16:23:00.307000+00:00
Original source

pretty effective, but might lead to contention due to high concurrency, but I can't really think of any scenarios where this would be a problem, Shauren might
rektbyfaith
01-29-2025, 04:23 PM #6

Archived author: Telegrill • Posted: 2025-01-29T16:23:00.307000+00:00
Original source

pretty effective, but might lead to contention due to high concurrency, but I can't really think of any scenarios where this would be a problem, Shauren might

rektbyfaith
Administrator
0
01-29-2025, 04:24 PM
#7
Archived author: Telegrill • Posted: 2025-01-29T16:24:39.356000+00:00
Original source

well, any scenarios where this would lead to the problem*
rektbyfaith
01-29-2025, 04:24 PM #7

Archived author: Telegrill • Posted: 2025-01-29T16:24:39.356000+00:00
Original source

well, any scenarios where this would lead to the problem*

rektbyfaith
Administrator
0
01-29-2025, 05:30 PM
#8
Archived author: ModoX • Posted: 2025-01-29T17:30:05.675000+00:00
Original source

fixed
rektbyfaith
01-29-2025, 05:30 PM #8

Archived author: ModoX • Posted: 2025-01-29T17:30:05.675000+00:00
Original source

fixed

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)