[DiscordArchive] I think in master the arcane charges are buffs and not power?
[DiscordArchive] I think in master the arcane charges are buffs and not power?
Original source
I think in master the arcane charges are buffs and not power?
rektbyfaith
01-11-2025, 06:49 PM #1Archived author: Drikish • Posted: 2025-01-11T18:49:06.988000+00:00
Original source
I think in master the arcane charges are buffs and not power?
Original source
nope take that back
rektbyfaith
01-11-2025, 06:49 PM #2Archived author: Drikish • Posted: 2025-01-11T18:49:30.508000+00:00
Original source
nope take that back
Original source
```c++
// Consume all arcane charges
if (int32 arcaneCharges = -caster->ModifyPower(POWER_ARCANE_CHARGES, -caster->GetMaxPower(POWER_ARCANE_CHARGES), false))
if (AuraEffect const* auraEffect = caster->GetAuraEffect(SPELL_MAGE_ARCANE_BARRAGE_R3, EFFECT_0, caster->GetGUID()))
caster->CastSpell(caster, SPELL_MAGE_ARCANE_BARRAGE_ENERGIZE, { SPELLVALUE_BASE_POINT0, arcaneCharges * auraEffect->GetAmount() / 100 });
```
Master ^
rektbyfaith
01-11-2025, 06:49 PM #3Archived author: Drikish • Posted: 2025-01-11T18:49:40.376000+00:00
Original source
```c++
// Consume all arcane charges
if (int32 arcaneCharges = -caster->ModifyPower(POWER_ARCANE_CHARGES, -caster->GetMaxPower(POWER_ARCANE_CHARGES), false))
if (AuraEffect const* auraEffect = caster->GetAuraEffect(SPELL_MAGE_ARCANE_BARRAGE_R3, EFFECT_0, caster->GetGUID()))
caster->CastSpell(caster, SPELL_MAGE_ARCANE_BARRAGE_ENERGIZE, { SPELLVALUE_BASE_POINT0, arcaneCharges * auraEffect->GetAmount() / 100 });
```
Master ^
Original source
also you don't need to store the _primaryTarget, you have GetExplTargetUnit for that
rektbyfaith
01-11-2025, 06:49 PM #4Archived author: Northstrider • Posted: 2025-01-11T18:49:51.793000+00:00
Original source
also you don't need to store the _primaryTarget, you have GetExplTargetUnit for that
Original source
That comes from master also
rektbyfaith
01-11-2025, 06:50 PM #5Archived author: Drikish • Posted: 2025-01-11T18:50:09.798000+00:00
Original source
That comes from master also
Original source
```c++
void MarkPrimaryTarget(SpellEffIndex /*effIndex*/)
{
_primaryTarget = GetHitUnit()->GetGUID();
}
```
rektbyfaith
01-11-2025, 06:50 PM #6Archived author: Drikish • Posted: 2025-01-11T18:50:13.742000+00:00
Original source
```c++
void MarkPrimaryTarget(SpellEffIndex /*effIndex*/)
{
_primaryTarget = GetHitUnit()->GetGUID();
}
```
Original source
https://github.com/TrinityCore/TrinityCo...e.cpp#L177
rektbyfaith
01-11-2025, 06:50 PM #7Archived author: Drikish • Posted: 2025-01-11T18:50:27.463000+00:00
Original source
https://github.com/TrinityCore/TrinityCo...e.cpp#L177
Original source
This handles whether or not the primary target is hit and if not it reduces the damage by effectIndex 1
rektbyfaith
01-11-2025, 06:51 PM #8Archived author: Drikish • Posted: 2025-01-11T18:51:04.914000+00:00
Original source
This handles whether or not the primary target is hit and if not it reduces the damage by effectIndex 1
Original source
But it doesn't seem to handle Resonance which Shauren pointed out still exists so maybe thats just handled by the aura system automatically?
rektbyfaith
01-11-2025, 06:51 PM #9Archived author: Drikish • Posted: 2025-01-11T18:51:26.506000+00:00
Original source
But it doesn't seem to handle Resonance which Shauren pointed out still exists so maybe thats just handled by the aura system automatically?
Original source
it doesn't handle the talent because it's not implemented. There is a 'new' hook to modify pct damage bonus
rektbyfaith
01-11-2025, 06:52 PM #10Archived author: Northstrider • Posted: 2025-01-11T18:52:05.807000+00:00
Original source
it doesn't handle the talent because it's not implemented. There is a 'new' hook to modify pct damage bonus