[DiscordArchive] okay, Plan B, from a cursory glance, is it possible that these proto files are only ever used in the
[DiscordArchive] okay, Plan B, from a cursory glance, is it possible that these proto files are only ever used in the
Original source
okay, Plan B, from a cursory glance, is it possible that these proto files are only ever used in the bnetserver, and not in the worldserver?
rektbyfaith
11-15-2024, 11:09 PM #1Archived author: Azarchius • Posted: 2024-11-15T23:09:49.223000+00:00
Original source
okay, Plan B, from a cursory glance, is it possible that these proto files are only ever used in the bnetserver, and not in the worldserver?
Original source
no
rektbyfaith
11-15-2024, 11:10 PM #2Archived author: Tea • Posted: 2024-11-15T23:10:00.135000+00:00
Original source
no
Original source
rat.
rektbyfaith
11-15-2024, 11:10 PM #3Archived author: Azarchius • Posted: 2024-11-15T23:10:05.979000+00:00
Original source
rat.
Original source
there's just a whole lot of shit, e.g. in protobuf it looks like
```cpp
pb::SplitStringUsing(file_->package(), ".", &package_parts_);
```
should be refactored into
```cpp
for (absl:
tring_view split_piece : absl::StrSplit(file_->package(), ".", absl::SkipEmpty())){
package_parts_.push_back(std:
tring(split_piece));}
```
rektbyfaith
11-15-2024, 11:41 PM #4Archived author: Azarchius • Posted: 2024-11-15T23:41:24.268000+00:00
Original source
there's just a whole lot of shit, e.g. in protobuf it looks like
```cpp
pb::SplitStringUsing(file_->package(), ".", &package_parts_);
```
should be refactored into
```cpp
for (absl:tring_view split_piece : absl::StrSplit(file_->package(), ".", absl::SkipEmpty()))
{
package_parts_.push_back(std:tring(split_piece));
}
```
Original source
the worst part is that I can't quite tell exactly how much shit like this I need to fix, there's like 10 errors, hopefully that's all..
rektbyfaith
11-15-2024, 11:41 PM #5Archived author: Azarchius • Posted: 2024-11-15T23:41:59.231000+00:00
Original source
the worst part is that I can't quite tell exactly how much shit like this I need to fix, there's like 10 errors, hopefully that's all..
1 Guest(s)
1 Guest(s)