Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] And how does directly manipulating member variables solve this problem?

[DiscordArchive] And how does directly manipulating member variables solve this problem?

[DiscordArchive] And how does directly manipulating member variables solve this problem?

Pages (3): 1 2 3 Next
rektbyfaith
Administrator
0
06-13-2024, 10:41 PM
#1
Archived author: stoneharry • Posted: 2024-06-13T22:41:48.753000+00:00
Original source

And how does directly manipulating member variables solve this problem?
rektbyfaith
06-13-2024, 10:41 PM #1

Archived author: stoneharry • Posted: 2024-06-13T22:41:48.753000+00:00
Original source

And how does directly manipulating member variables solve this problem?

rektbyfaith
Administrator
0
06-13-2024, 10:42 PM
#2
Archived author: Foe • Posted: 2024-06-13T22:42:39.875000+00:00
Original source

To be fair, using setters/getters set you up for future logic (if/when it's needed) without having to change all your direct member variable calls ‍♂️
rektbyfaith
06-13-2024, 10:42 PM #2

Archived author: Foe • Posted: 2024-06-13T22:42:39.875000+00:00
Original source

To be fair, using setters/getters set you up for future logic (if/when it's needed) without having to change all your direct member variable calls ‍♂️

rektbyfaith
Administrator
0
06-13-2024, 10:42 PM
#3
Archived author: Foe • Posted: 2024-06-13T22:42:44.668000+00:00
Original source

Seems like a win/win for me
rektbyfaith
06-13-2024, 10:42 PM #3

Archived author: Foe • Posted: 2024-06-13T22:42:44.668000+00:00
Original source

Seems like a win/win for me

rektbyfaith
Administrator
0
06-13-2024, 10:42 PM
#4
Archived author: chipzz • Posted: 2024-06-13T22:42:49.831000+00:00
Original source

The behaviour isn't described anywhere, and arguably it should trigger whatever is supposed to be triggered when the timer expires. It doesn't
rektbyfaith
06-13-2024, 10:42 PM #4

Archived author: chipzz • Posted: 2024-06-13T22:42:49.831000+00:00
Original source

The behaviour isn't described anywhere, and arguably it should trigger whatever is supposed to be triggered when the timer expires. It doesn't

rektbyfaith
Administrator
0
06-13-2024, 10:43 PM
#5
Archived author: chipzz • Posted: 2024-06-13T22:43:41.963000+00:00
Original source

Fourth, you shouldn't be modifying the interval in the first place. I doubt theres a lot if any cases at all where this makes sense
rektbyfaith
06-13-2024, 10:43 PM #5

Archived author: chipzz • Posted: 2024-06-13T22:43:41.963000+00:00
Original source

Fourth, you shouldn't be modifying the interval in the first place. I doubt theres a lot if any cases at all where this makes sense

rektbyfaith
Administrator
0
06-13-2024, 10:43 PM
#6
Archived author: stoneharry • Posted: 2024-06-13T22:43:46.389000+00:00
Original source

It's a documentation issue, not a code problem. Direct variable manipulation does not help at all here, it only brings disadvantages.
rektbyfaith
06-13-2024, 10:43 PM #6

Archived author: stoneharry • Posted: 2024-06-13T22:43:46.389000+00:00
Original source

It's a documentation issue, not a code problem. Direct variable manipulation does not help at all here, it only brings disadvantages.

rektbyfaith
Administrator
0
06-13-2024, 10:43 PM
#7
Archived author: chipzz • Posted: 2024-06-13T22:43:58.631000+00:00
Original source

And for the few cases where it does make sense, you should probably delete your timer and make. a new one
rektbyfaith
06-13-2024, 10:43 PM #7

Archived author: chipzz • Posted: 2024-06-13T22:43:58.631000+00:00
Original source

And for the few cases where it does make sense, you should probably delete your timer and make. a new one

rektbyfaith
Administrator
0
06-13-2024, 10:44 PM
#8
Archived author: Foe • Posted: 2024-06-13T22:44:00.324000+00:00
Original source

That really depends on the internal variable though..
rektbyfaith
06-13-2024, 10:44 PM #8

Archived author: Foe • Posted: 2024-06-13T22:44:00.324000+00:00
Original source

That really depends on the internal variable though..

rektbyfaith
Administrator
0
06-13-2024, 10:44 PM
#9
Archived author: stoneharry • Posted: 2024-06-13T22:44:09.282000+00:00
Original source

One does not need to solve use cases that are not likely to occur
rektbyfaith
06-13-2024, 10:44 PM #9

Archived author: stoneharry • Posted: 2024-06-13T22:44:09.282000+00:00
Original source

One does not need to solve use cases that are not likely to occur

rektbyfaith
Administrator
0
06-13-2024, 10:44 PM
#10
Archived author: Foe • Posted: 2024-06-13T22:44:23.339000+00:00
Original source

If you shouldn't modify a variable, you shouldn't have an externally available setter
rektbyfaith
06-13-2024, 10:44 PM #10

Archived author: Foe • Posted: 2024-06-13T22:44:23.339000+00:00
Original source

If you shouldn't modify a variable, you shouldn't have an externally available setter

Pages (3): 1 2 3 Next
Recently Browsing
 
Recently Browsing