Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] hmm ?

[DiscordArchive] hmm ?

[DiscordArchive] hmm ?

rektbyfaith
Administrator
0
03-10-2024, 06:38 PM
#1
Archived author: jackpoz • Posted: 2023-07-31T09:04:28.442000+00:00
Original source

Hmm ?
rektbyfaith
03-10-2024, 06:38 PM #1

Archived author: jackpoz • Posted: 2023-07-31T09:04:28.442000+00:00
Original source

Hmm ?

rektbyfaith
Administrator
0
03-10-2024, 06:42 PM
#2
Archived author: Pursche • Posted: 2024-03-10T18:42:47.858000+00:00
Original source

You have no tools surrounding the server itself, no editors, no serverside debug rendering, you don't have automated testing and regression tracking, you don't have have a docker environment.

If we focus on the things you DO have, which is a server somewhat emulating what Blizzard does, you're horribly object oriented with no regard for cache locality or performance. You have hardcoded spellfixes in code which should be data driven. You're still using +0.5f fixes to blink despite me presenting a fix for this two years ago.

As someone who works in the industry, with experience of MMO development, sure there are projects who have absolutely horrible quality (New World and being able to drag the window to avoid taking damage for example), but generally speaking we would not expect to see these things. It's an indicator of an enormous amount of tech debt.

That being said, I respect TC (and the emulators whose shoulders you stand on) and how relatively close it's getting to emulating WoW on a functional level. But to say that the tech is on the level of real MMORPGs is an enormous stretch.
rektbyfaith
03-10-2024, 06:42 PM #2

Archived author: Pursche • Posted: 2024-03-10T18:42:47.858000+00:00
Original source

You have no tools surrounding the server itself, no editors, no serverside debug rendering, you don't have automated testing and regression tracking, you don't have have a docker environment.

If we focus on the things you DO have, which is a server somewhat emulating what Blizzard does, you're horribly object oriented with no regard for cache locality or performance. You have hardcoded spellfixes in code which should be data driven. You're still using +0.5f fixes to blink despite me presenting a fix for this two years ago.

As someone who works in the industry, with experience of MMO development, sure there are projects who have absolutely horrible quality (New World and being able to drag the window to avoid taking damage for example), but generally speaking we would not expect to see these things. It's an indicator of an enormous amount of tech debt.

That being said, I respect TC (and the emulators whose shoulders you stand on) and how relatively close it's getting to emulating WoW on a functional level. But to say that the tech is on the level of real MMORPGs is an enormous stretch.

rektbyfaith
Administrator
0
03-10-2024, 06:43 PM
#3
Archived author: Pursche • Posted: 2024-03-10T18:43:39.293000+00:00
Original source

You have done an immense amount of reverse engineering to get it to this state and I'm thankful for that.
rektbyfaith
03-10-2024, 06:43 PM #3

Archived author: Pursche • Posted: 2024-03-10T18:43:39.293000+00:00
Original source

You have done an immense amount of reverse engineering to get it to this state and I'm thankful for that.

rektbyfaith
Administrator
0
03-10-2024, 06:43 PM
#4
Archived author: jackpoz • Posted: 2024-03-10T18:43:54.802000+00:00
Original source

how often do you see valgrind/helgrind/ASan/TSan in a real world program ?
rektbyfaith
03-10-2024, 06:43 PM #4

Archived author: jackpoz • Posted: 2024-03-10T18:43:54.802000+00:00
Original source

how often do you see valgrind/helgrind/ASan/TSan in a real world program ?

rektbyfaith
Administrator
0
03-10-2024, 06:44 PM
#5
Archived author: Pursche • Posted: 2024-03-10T18:44:04.423000+00:00
Original source

At every company I've worked for.
rektbyfaith
03-10-2024, 06:44 PM #5

Archived author: Pursche • Posted: 2024-03-10T18:44:04.423000+00:00
Original source

At every company I've worked for.

rektbyfaith
Administrator
0
03-10-2024, 06:44 PM
#6
Archived author: jackpoz • Posted: 2024-03-10T18:44:25.633000+00:00
Original source

which static and dynamic analysis tools do you have then ?
rektbyfaith
03-10-2024, 06:44 PM #6

Archived author: jackpoz • Posted: 2024-03-10T18:44:25.633000+00:00
Original source

which static and dynamic analysis tools do you have then ?

rektbyfaith
Administrator
0
03-10-2024, 06:44 PM
#7
Archived author: Pursche • Posted: 2024-03-10T18:44:37.560000+00:00
Original source

Address sanitation should run on every commit, worst case nightly.
rektbyfaith
03-10-2024, 06:44 PM #7

Archived author: Pursche • Posted: 2024-03-10T18:44:37.560000+00:00
Original source

Address sanitation should run on every commit, worst case nightly.

rektbyfaith
Administrator
0
03-10-2024, 06:44 PM
#8
Archived author: Pursche • Posted: 2024-03-10T18:44:57.178000+00:00
Original source

We use Valgrind
rektbyfaith
03-10-2024, 06:44 PM #8

Archived author: Pursche • Posted: 2024-03-10T18:44:57.178000+00:00
Original source

We use Valgrind

rektbyfaith
Administrator
0
03-10-2024, 06:45 PM
#9
Archived author: Pursche • Posted: 2024-03-10T18:45:41.259000+00:00
Original source

We use Tracy for performance testing, with the ability to run the performance tests in our CI pipeline.
rektbyfaith
03-10-2024, 06:45 PM #9

Archived author: Pursche • Posted: 2024-03-10T18:45:41.259000+00:00
Original source

We use Tracy for performance testing, with the ability to run the performance tests in our CI pipeline.

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)