[DiscordArchive] <@169121237539356673> ive been reading eluna source and i have a question, why are `Eluna::OnExpire`
[DiscordArchive] <@169121237539356673> ive been reading eluna source and i have a question, why are `Eluna::OnExpire`
Original source
one more question, ObjectGuid, where and how is it used on lua side? what would break if somebody wanted to change its representation from uint64 to string? (its 128 in modern client variants)
rektbyfaith
03-09-2024, 04:35 PM #21Archived author: Tea • Posted: 2024-03-09T16:35:54.041000+00:00
Original source
one more question, ObjectGuid, where and how is it used on lua side? what would break if somebody wanted to change its representation from uint64 to string? (its 128 in modern client variants)
Original source
It's cast to number Lua side (unsigned long long), so the cases where we cast would have to be changed
There's not very many methods where we actually use ObjectGuid as is, we primarily use GUID low
rektbyfaith
03-09-2024, 04:41 PM #22Archived author: Foe • Posted: 2024-03-09T16:41:42.619000+00:00
Original source
It's cast to number Lua side (unsigned long long), so the cases where we cast would have to be changed
There's not very many methods where we actually use ObjectGuid as is, we primarily use GUID low
Original source
https://github.com/ElunaLuaEngine/Eluna/...e.cpp#L545
[Embed: Eluna/LuaEngine.cpp at 9e32296c747197f86b5d4f5512838f75ff234d94 · E...]
Eluna Lua Engine © for WoW Emulators. Contribute to ElunaLuaEngine/Eluna development by creating an account on GitHub.
https://github.com/ElunaLuaEngine/Eluna/...Engine.cpp
rektbyfaith
03-09-2024, 04:42 PM #23Archived author: Foe • Posted: 2024-03-09T16:42:23.652000+00:00
Original source
https://github.com/ElunaLuaEngine/Eluna/...e.cpp#L545
[Embed: Eluna/LuaEngine.cpp at 9e32296c747197f86b5d4f5512838f75ff234d94 · E...]
Eluna Lua Engine © for WoW Emulators. Contribute to ElunaLuaEngine/Eluna development by creating an account on GitHub.
https://github.com/ElunaLuaEngine/Eluna/...Engine.cpp
Original source
This would be the primary to change
rektbyfaith
03-09-2024, 04:42 PM #24Archived author: Foe • Posted: 2024-03-09T16:42:31.689000+00:00
Original source
This would be the primary to change
Original source
And here https://github.com/ElunaLuaEngine/Eluna/...e.cpp#L651
[Embed: Eluna/LuaEngine.cpp at 9e32296c747197f86b5d4f5512838f75ff234d94 · E...]
Eluna Lua Engine © for WoW Emulators. Contribute to ElunaLuaEngine/Eluna development by creating an account on GitHub.
https://github.com/ElunaLuaEngine/Eluna/...Engine.cpp
rektbyfaith
03-09-2024, 04:42 PM #25Archived author: Foe • Posted: 2024-03-09T16:42:44.026000+00:00
Original source
And here https://github.com/ElunaLuaEngine/Eluna/...e.cpp#L651
[Embed: Eluna/LuaEngine.cpp at 9e32296c747197f86b5d4f5512838f75ff234d94 · E...]
Eluna Lua Engine © for WoW Emulators. Contribute to ElunaLuaEngine/Eluna development by creating an account on GitHub.
https://github.com/ElunaLuaEngine/Eluna/...Engine.cpp
Original source
that isnt going to work, full guid cannot be uniquely reconstructed from low
rektbyfaith
03-09-2024, 04:43 PM #26Archived author: Tea • Posted: 2024-03-09T16:43:21.151000+00:00
Original source
that isnt going to work, full guid cannot be uniquely reconstructed from low
Original source
Changing those two above should be the only two places to change that I can see at a glance, then we'd just have to treat them as strings instead of uint long long
rektbyfaith
03-09-2024, 04:47 PM #27Archived author: Foe • Posted: 2024-03-09T16:47:36.278000+00:00
Original source
Changing those two above should be the only two places to change that I can see at a glance, then we'd just have to treat them as strings instead of uint long long
Original source
guids arent supposed to be arithmetic anyway, you should only print them or pass back unmodified
rektbyfaith
03-09-2024, 04:48 PM #28Archived author: Tea • Posted: 2024-03-09T16:48:49.870000+00:00
Original source
guids arent supposed to be arithmetic anyway, you should only print them or pass back unmodified
Original source
All the engine side structs use ObjectGuid as is, so we'd just have to change the representation Lua side
rektbyfaith
03-09-2024, 04:48 PM #29Archived author: Foe • Posted: 2024-03-09T16:48:51.602000+00:00
Original source
All the engine side structs use ObjectGuid as is, so we'd just have to change the representation Lua side
Original source
Yeah
rektbyfaith
03-09-2024, 04:48 PM #30Archived author: Foe • Posted: 2024-03-09T16:48:57.647000+00:00
Original source
Yeah
1 Guest(s)
1 Guest(s)