[DiscordArchive] <@169121237539356673> ive been reading eluna source and i have a question, why are `Eluna::OnExpire`
[DiscordArchive] <@169121237539356673> ive been reading eluna source and i have a question, why are `Eluna::OnExpire`
Original source
<@169121237539356673> ive been reading eluna source and i have a question, why are `Eluna::OnExpire` and `Eluna::OnAdd` (itemhooks) calling `Push` on values when all other "hooks" use `HookPush`?
rektbyfaith
03-09-2024, 04:12 PM #1Archived author: Tea • Posted: 2024-03-09T16:12:24.481000+00:00
Original source
<@169121237539356673> ive been reading eluna source and i have a question, why are `Eluna::OnExpire` and `Eluna::OnAdd` (itemhooks) calling `Push` on values when all other "hooks" use `HookPush`?
Original source
Probably an oversight, previously both HookPush and Push were just called Push, but those were renamed to distinguish their functionality whenever we refactored for the multistate implementation
rektbyfaith
03-09-2024, 04:14 PM #2Archived author: Foe • Posted: 2024-03-09T16:14:17.542000+00:00
Original source
Probably an oversight, previously both HookPush and Push were just called Push, but those were renamed to distinguish their functionality whenever we refactored for the multistate implementation
Original source
and a bunch of mixed calls in inactive code pieces (in some #ifdes)
rektbyfaith
03-09-2024, 04:14 PM #3Archived author: Tea • Posted: 2024-03-09T16:14:51.686000+00:00
Original source
and a bunch of mixed calls in inactive code pieces (in some #ifdes)
Original source
yeah, the AzerothCore stuff should be removed tbh, they are maintaining their own fork, so none of that has been touched at all
rektbyfaith
03-09-2024, 04:15 PM #4Archived author: Foe • Posted: 2024-03-09T16:15:26.822000+00:00
Original source
yeah, the AzerothCore stuff should be removed tbh, they are maintaining their own fork, so none of that has been touched at all
Original source
Mangos is also not updated to the latest submodule either, they are still using C++11 so it's not compatible with the new refactor
rektbyfaith
03-09-2024, 04:15 PM #5Archived author: Foe • Posted: 2024-03-09T16:15:52.897000+00:00
Original source
Mangos is also not updated to the latest submodule either, they are still using C++11 so it's not compatible with the new refactor
Original source
actually its mostly CATA pieces where its been not maintained well
rektbyfaith
03-09-2024, 04:15 PM #6Archived author: Tea • Posted: 2024-03-09T16:15:57+00:00
Original source
actually its mostly CATA pieces where its been not maintained well
Original source
Yep, I don't think Niam put any effort into Cata at all since the cata preservation project got axed
rektbyfaith
03-09-2024, 04:16 PM #7Archived author: Foe • Posted: 2024-03-09T16:16:21.787000+00:00
Original source
Yep, I don't think Niam put any effort into Cata at all since the cata preservation project got axed
Original source
TC have CMake options to enable ASan btw
rektbyfaith
03-09-2024, 04:16 PM #8Archived author: jackpoz • Posted: 2024-03-09T16:16:23.342000+00:00
Original source
TC have CMake options to enable ASan btw
Original source
Cool, I will test that out
rektbyfaith
03-09-2024, 04:16 PM #9Archived author: Foe • Posted: 2024-03-09T16:16:33.227000+00:00
Original source
Cool, I will test that out
Original source
https://trinitycore.info/en/how-to/asan
[Embed: ASan]
how to use asan with trinitycore
https://trinitycore.info/en/how-to/asan
rektbyfaith
03-09-2024, 04:16 PM #10Archived author: jackpoz • Posted: 2024-03-09T16:16:50.497000+00:00
Original source
https://trinitycore.info/en/how-to/asan
[Embed: ASan]
how to use asan with trinitycore
https://trinitycore.info/en/how-to/asan