Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] No follow-up after PR has been amended as requested? https://github.com/TrinityCore/TrinityCore/pull

[DiscordArchive] No follow-up after PR has been amended as requested? https://github.com/TrinityCore/TrinityCore/pull

[DiscordArchive] No follow-up after PR has been amended as requested? https://github.com/TrinityCore/TrinityCore/pull

rektbyfaith
Administrator
0
05-19-2023, 12:31 PM
#1
Archived author: McDuck • Posted: 2023-05-19T12:31:37.251000+00:00
Original source

No follow-up after PR has been amended as requested? https://github.com/TrinityCore/TrinityCore/pull/28978 Do I need to make any more changes?
[Embed: Fixed the quest dialog could not be closed automatically after gett...]
Changes proposed:

Fixed the quest dialog could not be closed automatically after getting the quest reward when the quest giver has no other follow-up quests.
Add the const keyword to functions and...
https://github.com/TrinityCore/TrinityCore/pull/28978
rektbyfaith
05-19-2023, 12:31 PM #1

Archived author: McDuck • Posted: 2023-05-19T12:31:37.251000+00:00
Original source

No follow-up after PR has been amended as requested? https://github.com/TrinityCore/TrinityCore/pull/28978 Do I need to make any more changes?
[Embed: Fixed the quest dialog could not be closed automatically after gett...]
Changes proposed:

Fixed the quest dialog could not be closed automatically after getting the quest reward when the quest giver has no other follow-up quests.
Add the const keyword to functions and...
https://github.com/TrinityCore/TrinityCore/pull/28978

rektbyfaith
Administrator
0
05-19-2023, 12:40 PM
#2
Archived author: ModoX • Posted: 2023-05-19T12:40:09.643000+00:00
Original source

didnt have time to review and test about your assumptions on retail yet <@708294479731490817>
rektbyfaith
05-19-2023, 12:40 PM #2

Archived author: ModoX • Posted: 2023-05-19T12:40:09.643000+00:00
Original source

didnt have time to review and test about your assumptions on retail yet <@708294479731490817>

Recently Browsing
 
Recently Browsing