[DiscordArchive] Did you make a PR already?
[DiscordArchive] Did you make a PR already?
Archived author: MaxtorCoder • Posted: 2022-12-13T21:44:09.757000+00:00
Original source
Well you got the structure wrong
Archived author: MaxtorCoder • Posted: 2022-12-13T21:44:16.720000+00:00
Original source
+ I am sure Shauren has it updated
Archived author: MaxtorCoder • Posted: 2022-12-13T21:44:20.567000+00:00
Original source
ANYHHOW
Archived author: MaxtorCoder • Posted: 2022-12-13T21:44:34.987000+00:00
Original source
```cs
public static void ReadLearnedSpellInfo(Packet packet, params object[] indexes)
{
packet.ReadInt32<SpellId>("SpellId", indexes);
packet.ReadBit("IsFavorite", indexes);
var hasUnkBit1 = packet.ReadBit("HasUnk1", indexes);
var hasSuperceedsSpellID = packet.ReadBit("HasSuperceedsSpellID", indexes);
var hasTraitDefinitionID = packet.ReadBit("HasTraitDefinitionID", indexes);
packet.ResetBitReader();
if (hasUnkBit1)
packet.ReadInt32("Unk1", indexes);
if (hasSuperceedsSpellID)
packet.ReadInt32<SpellId>("SuperceedsSpellID", indexes);
if (hasTraitDefinitionID)
packet.ReadInt32("TraitDefinitionID", indexes);
}
[Parser(Opcode.SMSG_LEARNED_SPELLS)]
public static void HandleLearnedSpells(Packet packet)
{
var learnedSpellInfoCount = packet.ReadUInt32("LearnedSpellInfoCount");
packet.ReadUInt32("SpecializationID");
packet.ReadBit("SuppressMessaging");
packet.ResetBitReader();
for (var i = 0; i < learnedSpellInfoCount; ++i)
{
ReadLearnedSpellInfo(packet, i, "LearnedSpellInfo");
}
}
```
Archived author: MaxtorCoder • Posted: 2022-12-13T21:44:57.717000+00:00
Original source
That is the structure for it
Archived author: Tea • Posted: 2022-12-13T21:45:10.651000+00:00
Original source
its correct, HasUnk1 is unused so it gets no name
Archived author: MaxtorCoder • Posted: 2022-12-13T21:45:22.102000+00:00
Original source
IS it?
Archived author: MaxtorCoder • Posted: 2022-12-13T21:45:28.685000+00:00
Original source
It's still read as if statement
Archived author: MaxtorCoder • Posted: 2022-12-13T21:45:31.622000+00:00
Original source
Hence me adding it
Archived author: Tea • Posted: 2022-12-13T21:45:41.457000+00:00
Original source
oh i mean, unused in client handler