Forums WoW Modding Support Archives TrinityCore Discord Archives [DiscordArchive] There's a bug in Spell (at least in 335) that will still let you fail herb, skin and mining attempts

[DiscordArchive] There's a bug in Spell (at least in 335) that will still let you fail herb, skin and mining attempts

[DiscordArchive] There's a bug in Spell (at least in 335) that will still let you fail herb, skin and mining attempts

rektbyfaith
Administrator
0
09-02-2022, 06:05 AM
#1
Archived author: Saxxon • Posted: 2022-09-02T06:05:06.212000+00:00
Original source

There's a bug in Spell (at least in 335) that will still let you fail herb, skin and mining attempts. Strangely, it doesn't even try to cast, you just get SPELL_FAILED_TRY_AGAIN immediately. There's a couple other patches I am considering putting in a PR for (AI flee logic, linear profession skill gains, so on..) is there any process I should do before submitting these? Any accompanying documentation I should include? Are there any cases in which we would not want 100% same behavior?
rektbyfaith
09-02-2022, 06:05 AM #1

Archived author: Saxxon • Posted: 2022-09-02T06:05:06.212000+00:00
Original source

There's a bug in Spell (at least in 335) that will still let you fail herb, skin and mining attempts. Strangely, it doesn't even try to cast, you just get SPELL_FAILED_TRY_AGAIN immediately. There's a couple other patches I am considering putting in a PR for (AI flee logic, linear profession skill gains, so on..) is there any process I should do before submitting these? Any accompanying documentation I should include? Are there any cases in which we would not want 100% same behavior?

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)