[DiscordArchive] Maybe it's safer to just remove the image to force it to pull again, no?
[DiscordArchive] Maybe it's safer to just remove the image to force it to pull again, no?
Original source
But isn't it the container that needs to be rebuilt instead of the image?
rektbyfaith
06-03-2024, 01:58 PM #11Archived author: Dakeiz • Posted: 2024-06-03T13:58:36.502000+00:00
Original source
But isn't it the container that needs to be rebuilt instead of the image?
Original source
the image needs to be rebuilt, since there's code changes with the module. The container needs to be re-created, since we want the changes that are in the new image
rektbyfaith
06-03-2024, 02:02 PM #12Archived author: mynameismeat • Posted: 2024-06-03T14:02:09.062000+00:00
Original source
the image needs to be rebuilt, since there's code changes with the module. The container needs to be re-created, since we want the changes that are in the new image
Original source
But how does the image see changes in the modules? Modules/ is in my container volume, which isn't accessible within the image. Or is there something I'm missing?
rektbyfaith
06-03-2024, 02:03 PM #13Archived author: Dakeiz • Posted: 2024-06-03T14:03:21.902000+00:00
Original source
But how does the image see changes in the modules? Modules/ is in my container volume, which isn't accessible within the image. Or is there something I'm missing?
Original source
yeah, even if it's a volume, the `modules` section is still something that gets built with the images <https://github.com/azerothcore/azerothcore-wotlk/blob/master/apps/docker/Dockerfile#L75>
it sees changes in the modules based on how docker works. The gist is that in each step in a Dockerfile, a checksum is encoded into the image based on the inputs to the image build. Those inputs change, docker sees that, so it will rebuild with new changes.
rektbyfaith
06-03-2024, 02:06 PM #14Archived author: mynameismeat • Posted: 2024-06-03T14:06:31.417000+00:00
Original source
yeah, even if it's a volume, the `modules` section is still something that gets built with the images <https://github.com/azerothcore/azerothcore-wotlk/blob/master/apps/docker/Dockerfile#L75>
it sees changes in the modules based on how docker works. The gist is that in each step in a Dockerfile, a checksum is encoded into the image based on the inputs to the image build. Those inputs change, docker sees that, so it will rebuild with new changes.
Original source
Oh but wait!! So I should have a modules/ directory on my server right? So I should `git pull` on my host and not *inside* the container?
rektbyfaith
06-03-2024, 02:08 PM #15Archived author: Dakeiz • Posted: 2024-06-03T14:08:50.567000+00:00
Original source
Oh but wait!! So I should have a modules/ directory on my server right? So I should `git pull` on my host and not *inside* the container?
Original source
that's right, yeah
rektbyfaith
06-03-2024, 02:08 PM #16Archived author: mynameismeat • Posted: 2024-06-03T14:08:58.701000+00:00
Original source
that's right, yeah
Original source
Okay so now I understand. So I understand why you were telling me to build with a custom tag and then use it in my Compose file
rektbyfaith
06-03-2024, 02:14 PM #17Archived author: Dakeiz • Posted: 2024-06-03T14:14:43.264000+00:00
Original source
Okay so now I understand. So I understand why you were telling me to build with a custom tag and then use it in my Compose file
Original source
And after the container gets created once I can rollback to the "official" image because the changes've been applied, right?
rektbyfaith
06-03-2024, 02:15 PM #18Archived author: Dakeiz • Posted: 2024-06-03T14:15:13.595000+00:00
Original source
And after the container gets created once I can rollback to the "official" image because the changes've been applied, right?
Original source
no, the official image doesn't have mod-autobalance built into it, so it will basically be as if you didn't install it in the first place
rektbyfaith
06-03-2024, 02:16 PM #19Archived author: mynameismeat • Posted: 2024-06-03T14:16:43.978000+00:00
Original source
no, the official image doesn't have mod-autobalance built into it, so it will basically be as if you didn't install it in the first place
Original source
If I copied the Dockerfile and added a `git pull` command after the COPY, it would be easier, no?
rektbyfaith
06-03-2024, 02:23 PM #20Archived author: Dakeiz • Posted: 2024-06-03T14:23:13.495000+00:00
Original source
If I copied the Dockerfile and added a `git pull` command after the COPY, it would be easier, no?
1 Guest(s)
1 Guest(s)