[DiscordArchive] I think I'm misunderstanding, alignment how?
[DiscordArchive] I think I'm misunderstanding, alignment how?
Original source
I think I'm misunderstanding, alignment how?
rektbyfaith
08-30-2023, 03:25 PM #1Archived author: mynameismeat • Posted: 2023-08-30T15:25:23.691000+00:00
Original source
I think I'm misunderstanding, alignment how?
Original source
The variable names used in the docker config being the same as the variable names in the conf files
rektbyfaith
08-30-2023, 03:32 PM #2Archived author: AlexanderESmith • Posted: 2023-08-30T15:32:04.986000+00:00
Original source
The variable names used in the docker config being the same as the variable names in the conf files
Original source
I'm not sure if I'm missing some advantage to each having their own casing, underscores, periods, etc
rektbyfaith
08-30-2023, 03:32 PM #3Archived author: AlexanderESmith • Posted: 2023-08-30T15:32:43.036000+00:00
Original source
I'm not sure if I'm missing some advantage to each having their own casing, underscores, periods, etc
Original source
env vars are king
rektbyfaith
08-30-2023, 03:38 PM #4Archived author: Foe • Posted: 2023-08-30T15:38:45.319000+00:00
Original source
env vars are king
Original source
Oh, I see. The config file casing probably comes from MaNGOS? But it's normal to convert dotted PascalCase (or any capitalization format, really) to upper snakecase for environment variables. the official kafka docker containers stand out in my mind as something that does this
rektbyfaith
08-30-2023, 03:46 PM #5Archived author: mynameismeat • Posted: 2023-08-30T15:46:24.357000+00:00
Original source
Oh, I see. The config file casing probably comes from MaNGOS? But it's normal to convert dotted PascalCase (or any capitalization format, really) to upper snakecase for environment variables. the official kafka docker containers stand out in my mind as something that does this
Original source
I dont think we should change the naming, but maybe a debug logging option that'd make it so if enabled, it'll print "checking AC_ENV_VAR_NAME_BLAH for param Env.VarName" or something
rektbyfaith
08-30-2023, 03:47 PM #6Archived author: mynameismeat • Posted: 2023-08-30T15:47:04.161000+00:00
Original source
I dont think we should change the naming, but maybe a debug logging option that'd make it so if enabled, it'll print "checking AC_ENV_VAR_NAME_BLAH for param Env.VarName" or something
Original source
I tried to write some unit tests for this, maybe they can make your life easier - https://github.com/azerothcore/azerothco...Config.cpp
[Embed: azerothcore-wotlk/src/test/common/Configuration/Config.cpp at maste...]
Complete Open Source and Modular solution for MMO. Contribute to azerothcore/azerothcore-wotlk development by creating an account on GitHub.
https://github.com/azerothcore/azerothco...Config.cpp
rektbyfaith
08-30-2023, 03:48 PM #7Archived author: walkline • Posted: 2023-08-30T15:48:24.530000+00:00
Original source
I tried to write some unit tests for this, maybe they can make your life easier - https://github.com/azerothcore/azerothco...Config.cpp
[Embed: azerothcore-wotlk/src/test/common/Configuration/Config.cpp at maste...]
Complete Open Source and Modular solution for MMO. Contribute to azerothcore/azerothcore-wotlk development by creating an account on GitHub.
https://github.com/azerothcore/azerothco...Config.cpp
Original source
I'm more so having issues with modules not picking up the env var configs rather than getting the exact env var representation of a config name
rektbyfaith
08-30-2023, 03:49 PM #8Archived author: mynameismeat • Posted: 2023-08-30T15:49:27.902000+00:00
Original source
I'm more so having issues with modules not picking up the env var configs rather than getting the exact env var representation of a config name
Original source
but maybe it *is* a naming issue. Not sure, will need to figure it out
rektbyfaith
08-30-2023, 03:49 PM #9Archived author: mynameismeat • Posted: 2023-08-30T15:49:48.539000+00:00
Original source
but maybe it *is* a naming issue. Not sure, will need to figure it out
Original source
That will definitely help, thanks
rektbyfaith
08-30-2023, 03:49 PM #10Archived author: mynameismeat • Posted: 2023-08-30T15:49:56.497000+00:00
Original source
That will definitely help, thanks
1 Guest(s)
1 Guest(s)