[DiscordArchive] thanks <@456226577798135808> ! do you have a PR?
[DiscordArchive] thanks <@456226577798135808> ! do you have a PR?
Original source
thanks <@456226577798135808> ! do you have a PR?
rektbyfaith
01-28-2021, 09:47 PM #1Archived author: Shin • Posted: 2021-01-28T21:47:26.630000+00:00
Original source
thanks <@456226577798135808> ! do you have a PR?
Original source
No but I have a branch in the forked repo: https://github.com/tony-engineering/azer...-structure
Regarding the "data" folder: it is not a good practice to use a container "as a folder". Automating the step "downloading the data archive" won't bring much
[Embed: tony-engineering/azerothcore-wotlk]
Complete Open Source and Modular solution for MMO. Contribute to tony-engineering/azerothcore-wotlk development by creating an account on GitHub.
https://github.com/tony-engineering/azer...-structure
rektbyfaith
01-28-2021, 09:48 PM #2Archived author: Deleted User • Posted: 2021-01-28T21:48:36.097000+00:00
Original source
No but I have a branch in the forked repo: https://github.com/tony-engineering/azer...-structure
Regarding the "data" folder: it is not a good practice to use a container "as a folder". Automating the step "downloading the data archive" won't bring much
[Embed: tony-engineering/azerothcore-wotlk]
Complete Open Source and Modular solution for MMO. Contribute to tony-engineering/azerothcore-wotlk development by creating an account on GitHub.
https://github.com/tony-engineering/azer...-structure
Original source
<@456226577798135808> so what do you suggest instead?
rektbyfaith
01-28-2021, 09:52 PM #3Archived author: Shin • Posted: 2021-01-28T21:52:19.942000+00:00
Original source
<@456226577798135808> so what do you suggest instead?
Original source
continue tu use the current system, but simply the documentation so users don't forget this step (as I did :p )
rektbyfaith
01-28-2021, 09:56 PM #4Archived author: Deleted User • Posted: 2021-01-28T21:56:43.719000+00:00
Original source
continue tu use the current system, but simply the documentation so users don't forget this step (as I did :p )
Original source
With the refactoring I done, users only need to run one command `docker-compose up --build`
rektbyfaith
01-28-2021, 09:57 PM #5Archived author: Deleted User • Posted: 2021-01-28T21:57:11.091000+00:00
Original source
With the refactoring I done, users only need to run one command `docker-compose up --build`
Original source
+ download and extract the data archive
rektbyfaith
01-28-2021, 09:57 PM #6Archived author: Deleted User • Posted: 2021-01-28T21:57:33.731000+00:00
Original source
+ download and extract the data archive
Original source
To avoid having world-server and auth-server start before the db, I can add the "wait-for-it" script https://github.com/vishnubob/wait-for-it
[Embed: vishnubob/wait-for-it]
Pure bash script to test and wait on the availability of a TCP host and port - vishnubob/wait-for-it
https://github.com/vishnubob/wait-for-it
rektbyfaith
01-28-2021, 09:58 PM #7Archived author: Deleted User • Posted: 2021-01-28T21:58:53.250000+00:00
Original source
To avoid having world-server and auth-server start before the db, I can add the "wait-for-it" script https://github.com/vishnubob/wait-for-it
[Embed: vishnubob/wait-for-it]
Pure bash script to test and wait on the availability of a TCP host and port - vishnubob/wait-for-it
https://github.com/vishnubob/wait-for-it
Original source
Some explanations about my changes:
since word-server and auth-server are using the same code base (binaries are generated at the same time), I merged both Docker Images in "docker/server/Dockerfile". To start the image as auth-server, you need to set the variable START_AS_AUTHSERVER: "true"
rektbyfaith
01-28-2021, 10:02 PM #8Archived author: Deleted User • Posted: 2021-01-28T22:02:14.762000+00:00
Original source
Some explanations about my changes:
since word-server and auth-server are using the same code base (binaries are generated at the same time), I merged both Docker Images in "docker/server/Dockerfile". To start the image as auth-server, you need to set the variable START_AS_AUTHSERVER: "true"
Original source
I exploited the Docker multi-stage feature. everything is compiled in the `FROM ubuntu:20.04 as testable` stage. In order to stop the build at this stage we the --target flag: `docker build --target=testable server .` I am going to use this stage to run unit tests.
rektbyfaith
01-28-2021, 10:05 PM #9Archived author: Deleted User • Posted: 2021-01-28T22:05:03.055000+00:00
Original source
I exploited the Docker multi-stage feature. everything is compiled in the `FROM ubuntu:20.04 as testable` stage. In order to stop the build at this stage we the --target flag: `docker build --target=testable server .` I am going to use this stage to run unit tests.
Original source
that's great <@456226577798135808> , can you please add all this description in the PR once it will be opened? so the reviewers can better undertand your changes
rektbyfaith
01-28-2021, 10:06 PM #10Archived author: Shin • Posted: 2021-01-28T22:06:34.874000+00:00
Original source
that's great <@456226577798135808> , can you please add all this description in the PR once it will be opened? so the reviewers can better undertand your changes
1 Guest(s)
1 Guest(s)