[DiscordArchive] Are you aware of any recent changes to the assembler?
[DiscordArchive] Are you aware of any recent changes to the assembler?
Original source
Are you aware of any recent changes to the assembler?
rektbyfaith
06-07-2021, 08:02 AM #1Archived author: steen • Posted: 2021-06-07T08:02:42.006000+00:00
Original source
Are you aware of any recent changes to the assembler?
Original source
say, last 4-6 months
rektbyfaith
06-07-2021, 08:02 AM #2Archived author: steen • Posted: 2021-06-07T08:02:50.320000+00:00
Original source
say, last 4-6 months
Original source
fouuuuuuuuuuund the bug...
```
DB_AUTH_CONF=${DB_AUTH_CONF:-"MYSQL_USER='acore'; \
MYSQL_PASS='somenewpass'; \
MYSQL_HOST='localhost';\
MYSQL_PORT='3306';\
"}
```
IDK much about bash, but it looks like when I debug through this, the syntax:
`X=${X:-"somenewval"}` does not change the value of `X`
rektbyfaith
06-07-2021, 08:12 AM #3Archived author: steen • Posted: 2021-06-07T08:12:35.688000+00:00
Original source
fouuuuuuuuuuund the bug...
```
DB_AUTH_CONF=${DB_AUTH_CONF:-"MYSQL_USER='acore'; \
MYSQL_PASS='somenewpass'; \
MYSQL_HOST='localhost';\
MYSQL_PORT='3306';\
"}
```
IDK much about bash, but it looks like when I debug through this, the syntax:
`X=${X:-"somenewval"}` does not change the value of `X`
Original source
All right, so I fixed that bug by removing the `${DB_AUTH_CONF` and `}`
rektbyfaith
06-07-2021, 08:17 AM #4Archived author: steen • Posted: 2021-06-07T08:17:29.998000+00:00
Original source
All right, so I fixed that bug by removing the `${DB_AUTH_CONF` and `}`
Original source
Looks like <@!108617457836539904> introduced the defect as a part of this PR https://github.com/azerothcore/azerothco.../pull/4488 - I don't want to just make a PR to revert the change that caused it because I don't know what the intent of the change was.
[Embed: Feat(Docker/bash): docker-compose system rework by Yehonal · Pull R...]
⚠️ATTENTION! ⚠️ Upgrading procedure:
Database: After this PR will be merged you need to backup your DB first (you can use the db-assembler or any mysql client to generate the dump) and restore it a...
https://github.com/azerothcore/azerothco.../pull/4488
rektbyfaith
06-07-2021, 08:19 AM #5Archived author: steen • Posted: 2021-06-07T08:19:13.645000+00:00
Original source
Looks like <@!108617457836539904> introduced the defect as a part of this PR https://github.com/azerothcore/azerothco.../pull/4488 - I don't want to just make a PR to revert the change that caused it because I don't know what the intent of the change was.
[Embed: Feat(Docker/bash): docker-compose system rework by Yehonal · Pull R...]
⚠️ATTENTION! ⚠️ Upgrading procedure:
Database: After this PR will be merged you need to backup your DB first (you can use the db-assembler or any mysql client to generate the dump) and restore it a...
https://github.com/azerothcore/azerothco.../pull/4488
Original source
Sadly, with that defect fixed, the SQL updates are still silently failing to execute - onnnnn with the debugging :<
rektbyfaith
06-07-2021, 08:20 AM #6Archived author: steen • Posted: 2021-06-07T08:20:30.858000+00:00
Original source
Sadly, with that defect fixed, the SQL updates are still silently failing to execute - onnnnn with the debugging :<
Original source
Ok, 1 hour of debugging later, it looks like the issue is that the SQL the DB assembler generates contains every single update except the first one, the `2021_01_25_00.sql` update. Since each update has a check at the beginning that verifies that the previous update has run, *none* of the updates in the file run. This file happens to be the *last* SQL file of Azeroth Core 3.0.0, and is the only required update located in the `sql/archive/archive/3.x` folder.
rektbyfaith
06-07-2021, 08:56 AM #7Archived author: steen • Posted: 2021-06-07T08:56:50.097000+00:00
Original source
Ok, 1 hour of debugging later, it looks like the issue is that the SQL the DB assembler generates contains every single update except the first one, the `2021_01_25_00.sql` update. Since each update has a check at the beginning that verifies that the previous update has run, *none* of the updates in the file run. This file happens to be the *last* SQL file of Azeroth Core 3.0.0, and is the only required update located in the `sql/archive/archive/3.x` folder.
Original source
The TL;DR of this is that it looks like the db updater only works for upgrading within the same Azeroth Core version - I really wish I'd known this when I started
rektbyfaith
06-07-2021, 08:59 AM #8Archived author: steen • Posted: 2021-06-07T08:59:41.155000+00:00
Original source
The TL;DR of this is that it looks like the db updater only works for upgrading within the same Azeroth Core version - I really wish I'd known this when I started
Original source
I resolved this by manually running `2021_01_25_00.sql`, then running the db assembler again to apply the rest of the updates
rektbyfaith
06-07-2021, 09:05 AM #9Archived author: steen • Posted: 2021-06-07T09:05:59.344000+00:00
Original source
I resolved this by manually running `2021_01_25_00.sql`, then running the db assembler again to apply the rest of the updates
Original source
https://github.com/azerothcore/azerothco...tag/v3.0.0
That's where the Guides are to update from pre 3.0
[Embed: Release 3.0.0 · azerothcore/azerothcore-wotlk]
We suggest that you always use the latest version of our master branch.
Do NOT download the source code from the release, always use latest master version by following the official guide.
Upgrade i...
https://github.com/azerothcore/azerothco...tag/v3.0.0
rektbyfaith
06-07-2021, 09:13 AM #10Archived author: Honey • Posted: 2021-06-07T09:13:13.235000+00:00
Original source
https://github.com/azerothcore/azerothco...tag/v3.0.0
That's where the Guides are to update from pre 3.0
[Embed: Release 3.0.0 · azerothcore/azerothcore-wotlk]
We suggest that you always use the latest version of our master branch.
Do NOT download the source code from the release, always use latest master version by following the official guide.
Upgrade i...
https://github.com/azerothcore/azerothco...tag/v3.0.0
1 Guest(s)
1 Guest(s)