[DiscordArchive] Is the method intended to be used for binary values?
[DiscordArchive] Is the method intended to be used for binary values?
Archived author: Kitzunu • Posted: 2021-05-20T22:14:36.185000+00:00
Original source
Is the method intended to be used for binary values?
Archived author: Yehonal • Posted: 2021-05-20T22:14:54.111000+00:00
Original source
if you want to keep the other usage the same as they are now
Archived author: Roboto • Posted: 2021-05-20T22:14:56.383000+00:00
Original source
that's what I'm trying to do right now
Archived author: Roboto • Posted: 2021-05-20T22:15:05.485000+00:00
Original source
and it's the best solution imo
Archived author: Kitzunu • Posted: 2021-05-20T22:15:21.318000+00:00
Original source
in that case we could just keep it as-is and just revert the revert with no changes and you make a seperate PR for that?
Archived author: Yehonal • Posted: 2021-05-20T22:15:28.941000+00:00
Original source
GJ
Archived author: Kitzunu • Posted: 2021-05-20T22:15:55.279000+00:00
Original source
just make sure it doesnt break the two other places it is used x)
Archived author: Kitzunu • Posted: 2021-05-20T22:17:12.451000+00:00
Original source
<@!175631911450836993> if you create a PR and made sure that there are no undesired side effects it's fine by me to merge without outside tests
Archived author: Roboto • Posted: 2021-05-20T22:17:27.856000+00:00
Original source
alrighty
Archived author: Kitzunu • Posted: 2021-05-20T22:22:01.050000+00:00
Original source
<@!108617457836539904> could you approve the revert of the revert so I can merge it after roboto's PR?