[DiscordArchive] what needs to be done on the branch? you ported it over from TC right? so it should be fixed?
[DiscordArchive] what needs to be done on the branch? you ported it over from TC right? so it should be fixed?
Original source
what needs to be done on the branch? you ported it over from TC right? so it should be fixed?
rektbyfaith
04-17-2024, 05:50 PM #1Archived author: ttopper • Posted: 2024-04-17T17:50:14.069000+00:00
Original source
what needs to be done on the branch? you ported it over from TC right? so it should be fixed?
Original source
https://github.com/MellianStudios/azerot...ree/qaston
rektbyfaith
04-17-2024, 05:50 PM #2Archived author: Rymercyble • Posted: 2024-04-17T17:50:23.081000+00:00
Original source
https://github.com/MellianStudios/azerot...ree/qaston
Original source
i didnt port it
rektbyfaith
04-17-2024, 05:50 PM #3Archived author: Rymercyble • Posted: 2024-04-17T17:50:44.237000+00:00
Original source
i didnt port it
Original source
oh, you mean you just have a branch of AC, i see
rektbyfaith
04-17-2024, 05:50 PM #4Archived author: ttopper • Posted: 2024-04-17T17:50:56.507000+00:00
Original source
oh, you mean you just have a branch of AC, i see
Original source
i believe nefertum ported it or intelligentquantum im not sure who did more work like 2 years ago i just pulled it from git history and updated it to current AC
rektbyfaith
04-17-2024, 05:51 PM #5Archived author: Rymercyble • Posted: 2024-04-17T17:51:23.227000+00:00
Original source
i believe nefertum ported it or intelligentquantum im not sure who did more work like 2 years ago i just pulled it from git history and updated it to current AC
Original source
when you say "ported it" you mean the spell_proc system from trinitycore?
rektbyfaith
04-17-2024, 05:51 PM #6Archived author: ttopper • Posted: 2024-04-17T17:51:46.055000+00:00
Original source
when you say "ported it" you mean the spell_proc system from trinitycore?
Original source
yes
rektbyfaith
04-17-2024, 05:51 PM #7Archived author: Rymercyble • Posted: 2024-04-17T17:51:50.379000+00:00
Original source
yes
Original source
and it wasn't merged into master because it's unfinished in some way?
rektbyfaith
04-17-2024, 05:52 PM #8Archived author: ttopper • Posted: 2024-04-17T17:52:08.471000+00:00
Original source
and it wasn't merged into master because it's unfinished in some way?
Original source
it was merged but after 2 days it was reverted bcs it was not finished and then nobody ever touched it again
rektbyfaith
04-17-2024, 05:52 PM #9Archived author: Rymercyble • Posted: 2024-04-17T17:52:28.651000+00:00
Original source
it was merged but after 2 days it was reverted bcs it was not finished and then nobody ever touched it again
Original source
all spell scripts and all records in spell_proc_events are made to AC core logic which means that this change completely breaks them and all proc spells need to be fixed again
rektbyfaith
04-17-2024, 05:53 PM #10Archived author: Rymercyble • Posted: 2024-04-17T17:53:17.529000+00:00
Original source
all spell scripts and all records in spell_proc_events are made to AC core logic which means that this change completely breaks them and all proc spells need to be fixed again
1 Guest(s)
1 Guest(s)