[DiscordArchive] Is that the reason?
[DiscordArchive] Is that the reason?
Original source
Is that the reason?
If I add it here:
```php
AutoBalanceInflectionPointSettings getInflectionPointSettings (InstanceMap* instanceMap, bool isBoss = false, Player* player = nullptr)
```
will it fix the issue?
rektbyfaith
02-09-2024, 12:48 AM #1Archived author: adm • Posted: 2024-02-09T00:48:39.984000+00:00
Original source
Is that the reason?
If I add it here:
```php
AutoBalanceInflectionPointSettings getInflectionPointSettings (InstanceMap* instanceMap, bool isBoss = false, Player* player = nullptr)
```
will it fix the issue?
Original source
i have no idea u cant just randomly add new parameter to method u need to know if its supposed to be there
rektbyfaith
02-09-2024, 12:49 AM #2Archived author: Rymercyble • Posted: 2024-02-09T00:49:21.164000+00:00
Original source
i have no idea u cant just randomly add new parameter to method u need to know if its supposed to be there
Original source
Me too. My coding knowledge is very poor as everyone guessed
rektbyfaith
02-09-2024, 12:51 AM #3Archived author: adm • Posted: 2024-02-09T00:51:28.418000+00:00
Original source
Me too. My coding knowledge is very poor as everyone guessed
Original source
It actually compiled with the Player* player = nullptr Cheers
Now let's hope it doesn't crash
rektbyfaith
02-09-2024, 01:01 AM #4Archived author: adm • Posted: 2024-02-09T01:01:59.705000+00:00
Original source
It actually compiled with the Player* player = nullptr Cheers
Now let's hope it doesn't crash
Original source
just bcs it compiles doesnt mean anything since it didnt error on it previously that parameter is unused hence player will be always null and thus ur code will never work
rektbyfaith
02-09-2024, 01:03 AM #5Archived author: Rymercyble • Posted: 2024-02-09T01:03:08.971000+00:00
Original source
just bcs it compiles doesnt mean anything since it didnt error on it previously that parameter is unused hence player will be always null and thus ur code will never work
Original source
You can add any argument to the function, that doesn't mean it's used in calls or produce errors
rektbyfaith
02-09-2024, 01:03 AM #6Archived author: Revision • Posted: 2024-02-09T01:03:13.435000+00:00
Original source
You can add any argument to the function, that doesn't mean it's used in calls or produce errors
Original source
You have to find every reference to `getInflectionPointSettings` and pass the player object to it. Well the ones you need to
rektbyfaith
02-09-2024, 01:04 AM #7Archived author: Revision • Posted: 2024-02-09T01:04:09.744000+00:00
Original source
You have to find every reference to `getInflectionPointSettings` and pass the player object to it. Well the ones you need to
Original source
Yeah, it crashes
rektbyfaith
02-09-2024, 01:04 AM #8Archived author: adm • Posted: 2024-02-09T01:04:10.017000+00:00
Original source
Yeah, it crashes
Original source
You also need to null check the player
rektbyfaith
02-09-2024, 01:04 AM #9Archived author: Revision • Posted: 2024-02-09T01:04:46.142000+00:00
Original source
You also need to null check the player
Original source
It will always crash if player is null
rektbyfaith
02-09-2024, 01:04 AM #10Archived author: Revision • Posted: 2024-02-09T01:04:57.401000+00:00
Original source
It will always crash if player is null