Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] I ain't gonna mince words, why would AC knowingly and unabashedly merge an incomplete PR?

[DiscordArchive] I ain't gonna mince words, why would AC knowingly and unabashedly merge an incomplete PR?

[DiscordArchive] I ain't gonna mince words, why would AC knowingly and unabashedly merge an incomplete PR?

Pages (2): 1 2 Next
rektbyfaith
Administrator
0
09-27-2023, 11:00 PM
#1
Archived author: Bench • Posted: 2023-09-27T23:00:52.874000+00:00
Original source

I ain't gonna mince words, why would AC knowingly and unabashedly merge an incomplete PR?
rektbyfaith
09-27-2023, 11:00 PM #1

Archived author: Bench • Posted: 2023-09-27T23:00:52.874000+00:00
Original source

I ain't gonna mince words, why would AC knowingly and unabashedly merge an incomplete PR?

rektbyfaith
Administrator
0
09-27-2023, 11:00 PM
#2
Archived author: Revision • Posted: 2023-09-27T23:00:57.487000+00:00
Original source

You can't say *never* because you have absolutely no idea if it will be merged or not. If the game breaking stuff was fixed it would be merged.
rektbyfaith
09-27-2023, 11:00 PM #2

Archived author: Revision • Posted: 2023-09-27T23:00:57.487000+00:00
Original source

You can't say *never* because you have absolutely no idea if it will be merged or not. If the game breaking stuff was fixed it would be merged.

rektbyfaith
Administrator
0
09-27-2023, 11:02 PM
#3
Archived author: Rymercyble • Posted: 2023-09-27T23:02:31.293000+00:00
Original source

but that would require work....it was reverted in such way that even unfucking that mess takes hours and then also as we all know most of bigger projects here are more or less always one man show
rektbyfaith
09-27-2023, 11:02 PM #3

Archived author: Rymercyble • Posted: 2023-09-27T23:02:31.293000+00:00
Original source

but that would require work....it was reverted in such way that even unfucking that mess takes hours and then also as we all know most of bigger projects here are more or less always one man show

rektbyfaith
Administrator
0
09-27-2023, 11:02 PM
#4
Archived author: Revision • Posted: 2023-09-27T23:02:53.609000+00:00
Original source

Maybe, just maybe, instead of.. bitching, no better word for it, about the merging policy of AC you get to work on it? It might sound harsch but don't bash it unless you're willing to help fix it.
rektbyfaith
09-27-2023, 11:02 PM #4

Archived author: Revision • Posted: 2023-09-27T23:02:53.609000+00:00
Original source

Maybe, just maybe, instead of.. bitching, no better word for it, about the merging policy of AC you get to work on it? It might sound harsch but don't bash it unless you're willing to help fix it.

rektbyfaith
Administrator
0
09-27-2023, 11:03 PM
#5
Archived author: Bench • Posted: 2023-09-27T23:03:17.057000+00:00
Original source

Rymer's offered to try to pick up QAston if someone was willing to help him on it
rektbyfaith
09-27-2023, 11:03 PM #5

Archived author: Bench • Posted: 2023-09-27T23:03:17.057000+00:00
Original source

Rymer's offered to try to pick up QAston if someone was willing to help him on it

rektbyfaith
Administrator
0
09-27-2023, 11:04 PM
#6
Archived author: Revision • Posted: 2023-09-27T23:04:04.097000+00:00
Original source

Offering isn't the same as doing. Even if he'd be going solo for a while, at the start at least, it would be progress.
rektbyfaith
09-27-2023, 11:04 PM #6

Archived author: Revision • Posted: 2023-09-27T23:04:04.097000+00:00
Original source

Offering isn't the same as doing. Even if he'd be going solo for a while, at the start at least, it would be progress.

rektbyfaith
Administrator
0
09-27-2023, 11:04 PM
#7
Archived author: Revision • Posted: 2023-09-27T23:04:34.739000+00:00
Original source

I don't have the knowledge to do it nor do I even know what the point of it is meaning I don't really care either way (note: because I don't know what the benefit would be)
rektbyfaith
09-27-2023, 11:04 PM #7

Archived author: Revision • Posted: 2023-09-27T23:04:34.739000+00:00
Original source

I don't have the knowledge to do it nor do I even know what the point of it is meaning I don't really care either way (note: because I don't know what the benefit would be)

rektbyfaith
Administrator
0
09-27-2023, 11:06 PM
#8
Archived author: Revision • Posted: 2023-09-27T23:06:17.206000+00:00
Original source

Opening a PR for it, marking it as WIP, trying to get help to work on it in a separate fork/branch might be the way to go - assuming one isn't already open.
rektbyfaith
09-27-2023, 11:06 PM #8

Archived author: Revision • Posted: 2023-09-27T23:06:17.206000+00:00
Original source

Opening a PR for it, marking it as WIP, trying to get help to work on it in a separate fork/branch might be the way to go - assuming one isn't already open.

rektbyfaith
Administrator
0
09-27-2023, 11:06 PM
#9
Archived author: Rymercyble • Posted: 2023-09-27T23:06:39.979000+00:00
Original source

original branch was deleted
rektbyfaith
09-27-2023, 11:06 PM #9

Archived author: Rymercyble • Posted: 2023-09-27T23:06:39.979000+00:00
Original source

original branch was deleted

rektbyfaith
Administrator
0
09-27-2023, 11:07 PM
#10
Archived author: Rymercyble • Posted: 2023-09-27T23:07:53.480000+00:00
Original source

it is complete rework of spell procs if completed as its sideeffect it would also close many opened issues
rektbyfaith
09-27-2023, 11:07 PM #10

Archived author: Rymercyble • Posted: 2023-09-27T23:07:53.480000+00:00
Original source

it is complete rework of spell procs if completed as its sideeffect it would also close many opened issues

Pages (2): 1 2 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)