Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] Quick request for advice - I'm going to be making a PR to add a script hook when a GameObject's heal

[DiscordArchive] Quick request for advice - I'm going to be making a PR to add a script hook when a GameObject's heal

[DiscordArchive] Quick request for advice - I'm going to be making a PR to add a script hook when a GameObject's heal

rektbyfaith
Administrator
0
09-27-2023, 06:54 PM
#1
Archived author: KJack • Posted: 2023-09-27T18:54:11.867000+00:00
Original source

Quick request for advice - I'm going to be making a PR to add a script hook when a GameObject's health is modified. I see a couple of different conventions on how to name hooks (`OnDamage`, `DealDamage`, `ModifyMeleeDamage`, etc). If my intention is to be able to change the amount of damage that game object takes, what name should I go for?
rektbyfaith
09-27-2023, 06:54 PM #1

Archived author: KJack • Posted: 2023-09-27T18:54:11.867000+00:00
Original source

Quick request for advice - I'm going to be making a PR to add a script hook when a GameObject's health is modified. I see a couple of different conventions on how to name hooks (`OnDamage`, `DealDamage`, `ModifyMeleeDamage`, etc). If my intention is to be able to change the amount of damage that game object takes, what name should I go for?

rektbyfaith
Administrator
0
09-27-2023, 06:56 PM
#2
Archived author: KJack • Posted: 2023-09-27T18:56:24.597000+00:00
Original source

specifically adding it in this function:
https://github.com/azerothcore/azerothco....cpp#L2277
[Embed: azerothcore-wotlk/src/server/game/Entities/GameObject/GameObject.cp...]
Complete Open Source and Modular solution for MMO. Contribute to azerothcore/azerothcore-wotlk development by creating an account on GitHub.
https://github.com/azerothcore/azerothco...Object.cpp
rektbyfaith
09-27-2023, 06:56 PM #2

Archived author: KJack • Posted: 2023-09-27T18:56:24.597000+00:00
Original source

specifically adding it in this function:
https://github.com/azerothcore/azerothco....cpp#L2277
[Embed: azerothcore-wotlk/src/server/game/Entities/GameObject/GameObject.cp...]
Complete Open Source and Modular solution for MMO. Contribute to azerothcore/azerothcore-wotlk development by creating an account on GitHub.
https://github.com/azerothcore/azerothco...Object.cpp

rektbyfaith
Administrator
0
09-27-2023, 06:58 PM
#3
Archived author: KJack • Posted: 2023-09-27T18:58:38.833000+00:00
Original source

`OnGameObjectModifyHealth`?

`ModifyGameObjectHealthModify` is accurate but very confusing

`ModifyGameObjectHealthChange` might work
rektbyfaith
09-27-2023, 06:58 PM #3

Archived author: KJack • Posted: 2023-09-27T18:58:38.833000+00:00
Original source

`OnGameObjectModifyHealth`?

`ModifyGameObjectHealthModify` is accurate but very confusing

`ModifyGameObjectHealthChange` might work

rektbyfaith
Administrator
0
09-27-2023, 07:04 PM
#4
Archived author: KJack • Posted: 2023-09-27T19:04:12.422000+00:00
Original source

just want to know what's likely to get approved.
rektbyfaith
09-27-2023, 07:04 PM #4

Archived author: KJack • Posted: 2023-09-27T19:04:12.422000+00:00
Original source

just want to know what's likely to get approved.

rektbyfaith
Administrator
0
09-27-2023, 07:21 PM
#5
Archived author: 郑佩茹 • Posted: 2023-09-27T19:21:56.526000+00:00
Original source

OnGameObjectModifyHealth sounds good to me.
rektbyfaith
09-27-2023, 07:21 PM #5

Archived author: 郑佩茹 • Posted: 2023-09-27T19:21:56.526000+00:00
Original source

OnGameObjectModifyHealth sounds good to me.

rektbyfaith
Administrator
0
09-27-2023, 08:17 PM
#6
Archived author: Dreathean • Posted: 2023-09-27T20:17:33.766000+00:00
Original source

There isn't an "official" one, but one of the developers Liyunfan did start a playerbots Discord at https://discord.gg/NQm5QShwf9 which at the moment has a number of people in it though it is not super active
rektbyfaith
09-27-2023, 08:17 PM #6

Archived author: Dreathean • Posted: 2023-09-27T20:17:33.766000+00:00
Original source

There isn't an "official" one, but one of the developers Liyunfan did start a playerbots Discord at https://discord.gg/NQm5QShwf9 which at the moment has a number of people in it though it is not super active

rektbyfaith
Administrator
0
09-27-2023, 08:22 PM
#7
Archived author: brian8544 • Posted: 2023-09-27T20:22:08.566000+00:00
Original source

Aah I'm in there already, thought it was made by randoms, or dead, since no layout, etc. Thanks!
rektbyfaith
09-27-2023, 08:22 PM #7

Archived author: brian8544 • Posted: 2023-09-27T20:22:08.566000+00:00
Original source

Aah I'm in there already, thought it was made by randoms, or dead, since no layout, etc. Thanks!

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)