[DiscordArchive] https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/apps/worldserver/worldserver
[DiscordArchive] https://github.com/azerothcore/azerothcore-wotlk/blob/master/src/server/apps/worldserver/worldserver
Original source
Interesting
rektbyfaith
02-25-2023, 06:03 PM #21Archived author: Revision • Posted: 2023-02-25T18:03:53.785000+00:00
Original source
Interesting
Original source
i dont want to delete that functionality but it would be nice to be able to turn it off for some1 like me
rektbyfaith
02-25-2023, 06:04 PM #22Archived author: Rymercyble • Posted: 2023-02-25T18:04:41.433000+00:00
Original source
i dont want to delete that functionality but it would be nice to be able to turn it off for some1 like me
Original source
Yes, it would be a nice feature so people can choose what they want to do - not the very basic people of course.
rektbyfaith
02-25-2023, 06:05 PM #23Archived author: Revision • Posted: 2023-02-25T18:05:25.558000+00:00
Original source
Yes, it would be a nice feature so people can choose what they want to do - not the very basic people of course.
Original source
You just have to create a new log appender for config errors and change the error output line in the core
rektbyfaith
02-25-2023, 06:18 PM #24Archived author: Foe • Posted: 2023-02-25T18:18:08.325000+00:00
Original source
You just have to create a new log appender for config errors and change the error output line in the core
Original source
Would be simpler if you add a bool config option that if you want your config only to have select options you have to add that one and set it to true. When true it doesn't complain about the missing config options.
rektbyfaith
02-25-2023, 06:31 PM #25Archived author: Revision • Posted: 2023-02-25T18:31:15.746000+00:00
Original source
Would be simpler if you add a bool config option that if you want your config only to have select options you have to add that one and set it to true. When true it doesn't complain about the missing config options.
Original source
that was my first thought to do
rektbyfaith
02-25-2023, 06:31 PM #26Archived author: Rymercyble • Posted: 2023-02-25T18:31:44.138000+00:00
Original source
that was my first thought to do
Original source
When I fix a single issue but need to touch different parts (DB and Instance Script) to do so, can I create a single PR? How should I call it? In theory I would need both:
fix(Script/Instance)
fix(DB/SAI)
rektbyfaith
02-25-2023, 06:51 PM #27Archived author: Johaine • Posted: 2023-02-25T18:51:22.251000+00:00
Original source
When I fix a single issue but need to touch different parts (DB and Instance Script) to do so, can I create a single PR? How should I call it? In theory I would need both:
fix(Script/Instance)
fix(DB/SAI)
Original source
If they are related there's no need to create multiple PRs. Say if you want to fix a boss in a raid and some adds use SAI, they are still related.
rektbyfaith
02-25-2023, 06:56 PM #28Archived author: Revision • Posted: 2023-02-25T18:56:12.802000+00:00
Original source
If they are related there's no need to create multiple PRs. Say if you want to fix a boss in a raid and some adds use SAI, they are still related.
Original source
Ok, the main fix is in DB/SAI so I'll use that
rektbyfaith
02-25-2023, 06:57 PM #29Archived author: Johaine • Posted: 2023-02-25T18:57:19.609000+00:00
Original source
Ok, the main fix is in DB/SAI so I'll use that
Original source
Again, only if they're directly related
rektbyfaith
02-25-2023, 06:58 PM #30Archived author: Revision • Posted: 2023-02-25T18:58:13.926000+00:00
Original source
Again, only if they're directly related
1 Guest(s)
1 Guest(s)