[DiscordArchive] You could bring it up here because I'm not sure creating an issue report for a bug that may or may n
[DiscordArchive] You could bring it up here because I'm not sure creating an issue report for a bug that may or may n
Original source
You could bring it up here because I'm not sure creating an issue report for a bug that may or may not exist is valid. What is the issue that requires 6+ characters online?
rektbyfaith
02-24-2023, 06:01 PM #1Archived author: Revision • Posted: 2023-02-24T18:01:47.545000+00:00
Original source
You could bring it up here because I'm not sure creating an issue report for a bug that may or may not exist is valid. What is the issue that requires 6+ characters online?
Original source
Ok, here I go: Lets say you have 50 DDs, 2 healers and no tank queued in the LFG. You as a DD have waited for a long time and get an invite, because now 1 tank has queued. 1 tank, 1 healer and 3 DDs get combined and get a dungeon invite. One of the DDs is AFK and the invite runs out.
On Blizzlike servers this would usually mean: I as a DD that accepted the invite get back into the queue at the very front and - because there are so many DDs - get another invite more or less instantly.
On AC (Chromiecraft) I've experienced that I get back into the queue and have to wait another 30 minutes. (Tank and Healer accepted the invite!)
I suspect the following to happen: After the invite runs out, the 4 accepting players get pushed to the front of the "restoredAfterProposal" and "newToQueueStore" (https://github.com/azerothcore/azerothco...ue.cpp#L85) BUT only one of those players to be put back into the real queue is processed per server tick (https://github.com/azerothcore/azerothco...r.cpp#L344)
Now the following could happen: 1 tank, 1 healer and 2 DDs need to be put back to the front of the queue. (Order may vary) There is already 1 healer and several DDs in the queue.
Tick 1: Tank is processed and FindGroup() is called and a proposal is found: 1 tank (from the previous proposal), 1 healer and 3 DDs (from the queue). They get a new proposal instantly.
Tick 2: The healer from the previous proposal is put back into the queue and a group is searched: No tank, no proposal
Tick 3: One DD from prev proposal put back into queue and a group is searched: No tank
Tick 4: See Tick 3
Now the Healer and the 2 DDs are back at the front of the queue but get no invite until the next tank queues.
rektbyfaith
02-24-2023, 06:14 PM #2Archived author: Johaine • Posted: 2023-02-24T18:14:32.597000+00:00
Original source
Ok, here I go: Lets say you have 50 DDs, 2 healers and no tank queued in the LFG. You as a DD have waited for a long time and get an invite, because now 1 tank has queued. 1 tank, 1 healer and 3 DDs get combined and get a dungeon invite. One of the DDs is AFK and the invite runs out.
On Blizzlike servers this would usually mean: I as a DD that accepted the invite get back into the queue at the very front and - because there are so many DDs - get another invite more or less instantly.
On AC (Chromiecraft) I've experienced that I get back into the queue and have to wait another 30 minutes. (Tank and Healer accepted the invite!)
I suspect the following to happen: After the invite runs out, the 4 accepting players get pushed to the front of the "restoredAfterProposal" and "newToQueueStore" (https://github.com/azerothcore/azerothco...ue.cpp#L85) BUT only one of those players to be put back into the real queue is processed per server tick (https://github.com/azerothcore/azerothco...r.cpp#L344)
Now the following could happen: 1 tank, 1 healer and 2 DDs need to be put back to the front of the queue. (Order may vary) There is already 1 healer and several DDs in the queue.
Tick 1: Tank is processed and FindGroup() is called and a proposal is found: 1 tank (from the previous proposal), 1 healer and 3 DDs (from the queue). They get a new proposal instantly.
Tick 2: The healer from the previous proposal is put back into the queue and a group is searched: No tank, no proposal
Tick 3: One DD from prev proposal put back into queue and a group is searched: No tank
Tick 4: See Tick 3
Now the Healer and the 2 DDs are back at the front of the queue but get no invite until the next tank queues.
Original source
This might have been introduced when this line was changed from "while (!newToQueueStore.empty())" to https://github.com/azerothcore/azerothco...e.cpp#L180
rektbyfaith
02-24-2023, 06:17 PM #3Archived author: Johaine • Posted: 2023-02-24T18:17:45.756000+00:00
Original source
This might have been introduced when this line was changed from "while (!newToQueueStore.empty())" to https://github.com/azerothcore/azerothco...e.cpp#L180
Original source
(In fact this code could be cleaned up because the counter in this superflous: If one match is found, we'll brake anyway. It can only return 0 if the newToQueueStore is empty or 1 if there is at least one entry.
rektbyfaith
02-24-2023, 06:19 PM #4Archived author: Johaine • Posted: 2023-02-24T18:19:11.058000+00:00
Original source
(In fact this code could be cleaned up because the counter in this superflous: If one match is found, we'll brake anyway. It can only return 0 if the newToQueueStore is empty or 1 if there is at least one entry.
Original source
Imho it would require testing from 1 tank, 2+ healers and 4+ DDs queuing in a specific order to check if the priority (waiting time in queue) is preserved if a LFG proposal times out.
rektbyfaith
02-24-2023, 06:21 PM #5Archived author: Johaine • Posted: 2023-02-24T18:21:57.038000+00:00
Original source
Imho it would require testing from 1 tank, 2+ healers and 4+ DDs queuing in a specific order to check if the priority (waiting time in queue) is preserved if a LFG proposal times out.
Original source
But maybe I'm also hallucinating
rektbyfaith
02-24-2023, 06:23 PM #6Archived author: Johaine • Posted: 2023-02-24T18:23:14.777000+00:00
Original source
But maybe I'm also hallucinating
Original source
It does sound like a real issue so I'd recommend creating an issue report for it so the most amount of people can (hopefully) test it. I'm sorry I got you to spend all that time writing it up here and I might be able to test it but not at the 'mo. I can easily test it though since I box enough to fit any requirements for that test.
rektbyfaith
02-24-2023, 06:33 PM #7Archived author: Revision • Posted: 2023-02-24T18:33:34.892000+00:00
Original source
It does sound like a real issue so I'd recommend creating an issue report for it so the most amount of people can (hopefully) test it. I'm sorry I got you to spend all that time writing it up here and I might be able to test it but not at the 'mo. I can easily test it though since I box enough to fit any requirements for that test.
Original source
You appear to have gathered a whole lot of information too which is always really helpful
rektbyfaith
02-24-2023, 06:34 PM #8Archived author: Revision • Posted: 2023-02-24T18:34:50.254000+00:00
Original source
You appear to have gathered a whole lot of information too which is always really helpful
Original source
Alright, thanks, will do so.
Also, no reason for an apology. Maybe I was just unlucky and would've got bombarded with "Works for me". Or maybe a few people could've confirmed the issue already.
rektbyfaith
02-24-2023, 07:00 PM #9Archived author: Johaine • Posted: 2023-02-24T19:00:06.551000+00:00
Original source
Alright, thanks, will do so.
Also, no reason for an apology. Maybe I was just unlucky and would've got bombarded with "Works for me". Or maybe a few people could've confirmed the issue already.
Original source
certain creature pages are missing
rektbyfaith
02-24-2023, 08:11 PM #10Archived author: Neifion • Posted: 2023-02-24T20:11:38.854000+00:00
Original source
certain creature pages are missing
1 Guest(s)
1 Guest(s)