Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] <@228769085834395648> is your branch good to go for a PR? Or who wants to PR it?

[DiscordArchive] <@228769085834395648> is your branch good to go for a PR? Or who wants to PR it?

[DiscordArchive] <@228769085834395648> is your branch good to go for a PR? Or who wants to PR it?

rektbyfaith
Administrator
Find
0
01-20-2023, 09:23 AM
#1
Archived author: Honey • Posted: 2023-01-20T09:23:56.455000+00:00
Original source

<@228769085834395648> is your branch good to go for a PR? Or who wants to PR it?
Reply
Reply
rektbyfaith
01-20-2023, 09:23 AM #1

Archived author: Honey • Posted: 2023-01-20T09:23:56.455000+00:00
Original source

<@228769085834395648> is your branch good to go for a PR? Or who wants to PR it?

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:25 AM
#2
Archived author: Anchy • Posted: 2023-01-20T09:25:17.330000+00:00
Original source

it needs to be reviewed and probably look at changed in some way
Reply
Reply
rektbyfaith
01-20-2023, 09:25 AM #2

Archived author: Anchy • Posted: 2023-01-20T09:25:17.330000+00:00
Original source

it needs to be reviewed and probably look at changed in some way

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:25 AM
#3
Archived author: Anchy • Posted: 2023-01-20T09:25:20.953000+00:00
Original source

and make it a config option
Reply
Reply
rektbyfaith
01-20-2023, 09:25 AM #3

Archived author: Anchy • Posted: 2023-01-20T09:25:20.953000+00:00
Original source

and make it a config option

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:25 AM
#4
Archived author: Anchy • Posted: 2023-01-20T09:25:41.579000+00:00
Original source

im no c++ genius so I'm sure the code quality could be better
Reply
Reply
rektbyfaith
01-20-2023, 09:25 AM #4

Archived author: Anchy • Posted: 2023-01-20T09:25:41.579000+00:00
Original source

im no c++ genius so I'm sure the code quality could be better

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:26 AM
#5
Archived author: Bench • Posted: 2023-01-20T09:26:17.875000+00:00
Original source

I mean my stuff's gotten merged, but to my novice eyes it looks alright ‍♀️
Reply
Reply
rektbyfaith
01-20-2023, 09:26 AM #5

Archived author: Bench • Posted: 2023-01-20T09:26:17.875000+00:00
Original source

I mean my stuff's gotten merged, but to my novice eyes it looks alright ‍♀️

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:26 AM
#6
Archived author: Anchy • Posted: 2023-01-20T09:26:37.423000+00:00
Original source

however if you do merge it, the way it's setup now it should not mess with a normal server at all
Reply
Reply
rektbyfaith
01-20-2023, 09:26 AM #6

Archived author: Anchy • Posted: 2023-01-20T09:26:37.423000+00:00
Original source

however if you do merge it, the way it's setup now it should not mess with a normal server at all

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:26 AM
#7
Archived author: Anchy • Posted: 2023-01-20T09:26:44.883000+00:00
Original source

only if a module calls the new exposed functions
Reply
Reply
rektbyfaith
01-20-2023, 09:26 AM #7

Archived author: Anchy • Posted: 2023-01-20T09:26:44.883000+00:00
Original source

only if a module calls the new exposed functions

Reply
Reply
rektbyfaith
Administrator
Find
0
01-20-2023, 09:27 AM
#8
Archived author: Anchy • Posted: 2023-01-20T09:27:04.179000+00:00
Original source

Warden should still function the same as before
Reply
Reply
rektbyfaith
01-20-2023, 09:27 AM #8

Archived author: Anchy • Posted: 2023-01-20T09:27:04.179000+00:00
Original source

Warden should still function the same as before

Reply
Reply
Recently Browsing
 
Recently Browsing