[DiscordArchive] Should I open a PR to fix this file directly?
[DiscordArchive] Should I open a PR to fix this file directly?
Original source
Should I open a PR to fix this file directly?
rektbyfaith
10-17-2022, 07:55 PM #1Archived author: 郑佩茹 • Posted: 2022-10-17T19:55:40.750000+00:00
Original source
Should I open a PR to fix this file directly?
Original source
i don't think we can fix already imported files
rektbyfaith
10-17-2022, 07:56 PM #2Archived author: Honey • Posted: 2022-10-17T19:56:04.234000+00:00
Original source
i don't think we can fix already imported files
Original source
we probably need to re-INSERT the missing rows
rektbyfaith
10-17-2022, 07:56 PM #3Archived author: Honey • Posted: 2022-10-17T19:56:29.896000+00:00
Original source
we probably need to re-INSERT the missing rows
Original source
It's been done before
rektbyfaith
10-17-2022, 07:56 PM #4Archived author: Bench • Posted: 2022-10-17T19:56:30.096000+00:00
Original source
It's been done before
Original source
cause if one has already updated, that fix wouldn't bring the missing rows back
rektbyfaith
10-17-2022, 07:56 PM #5Archived author: Honey • Posted: 2022-10-17T19:56:56.774000+00:00
Original source
cause if one has already updated, that fix wouldn't bring the missing rows back
Original source
The problem is that the rows that are deleted are depend on the context of the SQL database at the time. @GUID is undefined, so it is not certain which rows are deleted.
rektbyfaith
10-17-2022, 07:56 PM #6Archived author: 郑佩茹 • Posted: 2022-10-17T19:56:59.393000+00:00
Original source
The problem is that the rows that are deleted are depend on the context of the SQL database at the time. @GUID is undefined, so it is not certain which rows are deleted.
Original source
I am surprising that the CI did not error on the use of the undefined variable.
rektbyfaith
10-17-2022, 07:59 PM #7Archived author: 郑佩茹 • Posted: 2022-10-17T19:59:35.151000+00:00
Original source
I am surprising that the CI did not error on the use of the undefined variable.
Original source
I have opened a PR to fix the error SQL file. I will also submit a fix to re-import the gameobject table as it should be at the current state after the fixed SQL is run. I think this fix will require to empty and repopulate the table because there is no way to know what data was deleted.
rektbyfaith
10-17-2022, 08:09 PM #8Archived author: 郑佩茹 • Posted: 2022-10-17T20:09:28.790000+00:00
Original source
I have opened a PR to fix the error SQL file. I will also submit a fix to re-import the gameobject table as it should be at the current state after the fixed SQL is run. I think this fix will require to empty and repopulate the table because there is no way to know what data was deleted.
1 Guest(s)
1 Guest(s)