[DiscordArchive] How Do I code review your DBC change?
[DiscordArchive] How Do I code review your DBC change?
Archived author: DavuKnight • Posted: 2022-09-01T19:32:05.525000+00:00
Original source
How Do I code review your DBC change?
Archived author: Rymercyble • Posted: 2022-09-01T19:32:47.393000+00:00
Original source
well u dont but there are nearly none dbc changes in base wotlk dbc at this point
Archived author: Bench • Posted: 2022-09-01T19:33:09.755000+00:00
Original source
Yea no, any DBC changes means custom content
Archived author: Rymercyble • Posted: 2022-09-01T19:33:12.360000+00:00
Original source
so
first step in server startup process
config contains new credentials for db (if not filled it uses world/char)
connects to db grabs all tables matching any dbc filename
exports all of their content to dbc files
continues startup
Archived author: Rymercyble • Posted: 2022-09-01T19:34:02.323000+00:00
Original source
actually that would help me a lot
Archived author: DavuKnight • Posted: 2022-09-01T19:35:26.949000+00:00
Original source
For example https://github.com/azerothcore/azerothco...1233891426 would be a DBC change if someone decides its something we want to do.
I was looking at it yesterday and as I did I was wondering how anyone would Code review it.
Archived author: Rymercyble • Posted: 2022-09-01T19:35:51.051000+00:00
Original source
but im not sure if its possible i dont know if even as first step of startup it isnt too late to change dbc bcs they could be already loaded
Archived author: Bench • Posted: 2022-09-01T19:35:53.286000+00:00
Original source
No, DBC changes are not something that is done
Archived author: Bench • Posted: 2022-09-01T19:36:50.252000+00:00
Original source
There are server-side spells which are contained in the spell_dbc table, but something like that isn't done
Archived author: DavuKnight • Posted: 2022-09-01T19:37:08.855000+00:00
Original source
Dont know think mod's might like it as an option.