[DiscordArchive] is there anything else i have to do for my pull request?
[DiscordArchive] is there anything else i have to do for my pull request?
Original source
is there anything else i have to do for my pull request?
rektbyfaith
07-27-2022, 12:05 AM #1Archived author: Anchy • Posted: 2022-07-27T00:05:00.200000+00:00
Original source
is there anything else i have to do for my pull request?
Original source
https://github.com/azerothcore/azerothco...pull/12538
rektbyfaith
07-27-2022, 12:05 AM #2Archived author: Anchy • Posted: 2022-07-27T00:05:05.109000+00:00
Original source
https://github.com/azerothcore/azerothco...pull/12538
Original source
i dont really know what im doing
rektbyfaith
07-27-2022, 12:07 AM #3Archived author: Anchy • Posted: 2022-07-27T00:07:01.342000+00:00
Original source
i dont really know what im doing
Original source
No, there is nothing else you need to do. The PR has been reviewed and approve, so now it just needs to pass testing. Once a tester has confirmed that it is working with no problems, then it will be merged. There is some backlog of testing PRs, so it may take some days for the testing team to do this. If you are having others also independently test it, that is also acceptable for pass the testing; anyone is able to test, as long as it is independent from submitter of the PR.
rektbyfaith
07-27-2022, 12:09 AM #4Archived author: 郑佩茹 • Posted: 2022-07-27T00:09:03.699000+00:00
Original source
No, there is nothing else you need to do. The PR has been reviewed and approve, so now it just needs to pass testing. Once a tester has confirmed that it is working with no problems, then it will be merged. There is some backlog of testing PRs, so it may take some days for the testing team to do this. If you are having others also independently test it, that is also acceptable for pass the testing; anyone is able to test, as long as it is independent from submitter of the PR.
Original source
it was merged 9 hours ago
rektbyfaith
07-27-2022, 12:09 AM #5Archived author: M'Dic • Posted: 2022-07-27T00:09:07.522000+00:00
Original source
it was merged 9 hours ago
Original source
ooh i see
rektbyfaith
07-27-2022, 12:09 AM #6Archived author: Anchy • Posted: 2022-07-27T00:09:28.361000+00:00
Original source
ooh i see
Original source
the person just forgot to thank you for the pr
rektbyfaith
07-27-2022, 12:09 AM #7Archived author: M'Dic • Posted: 2022-07-27T00:09:31.245000+00:00
Original source
the person just forgot to thank you for the pr
Original source
good job
rektbyfaith
07-27-2022, 12:09 AM #8Archived author: M'Dic • Posted: 2022-07-27T00:09:32.917000+00:00
Original source
good job
Original source
Thank you for the PR
rektbyfaith
07-27-2022, 12:09 AM #9Archived author: M'Dic • Posted: 2022-07-27T00:09:35.793000+00:00
Original source
Thank you for the PR
Original source
It seems it was merge while I was typing the response. Haha. ^_^
rektbyfaith
07-27-2022, 12:10 AM #10Archived author: 郑佩茹 • Posted: 2022-07-27T00:10:05.549000+00:00
Original source
It seems it was merge while I was typing the response. Haha. ^_^
1 Guest(s)
1 Guest(s)