[DiscordArchive] We still don't know, where you have found the outdated link?
[DiscordArchive] We still don't know, where you have found the outdated link?
Original source
Cause I'm talking about the failed check here
![[Image: IMG_20250121_173441.jpg?ex=690c258b&is=6...817244ad9&]](https://cdn.discordapp.com/attachments/448835144564867094/1331301129145028709/IMG_20250121_173441.jpg?ex=690c258b&is=690ad40b&hm=28b2d641f7153ffcd8313ec6938e1b5066d6ec4342673de8f0cb26f817244ad9&)
rektbyfaith
01-21-2025, 04:35 PM #11Archived author: Honey • Posted: 2025-01-21T16:35:23.619000+00:00
Original source
Cause I'm talking about the failed check here
Original source
This is not due to a bad way of doing c++ code but to the ElunaIncludes file, for example it is included in LuaEngine.cpp where we use eObjectAccessor() but the cppcheck does not pass because it does not find eObjectAccessor(), and this since before my PR ^^
rektbyfaith
01-21-2025, 04:35 PM #12Archived author: iThorgrim • Posted: 2025-01-21T16:35:38.817000+00:00
Original source
This is not due to a bad way of doing c++ code but to the ElunaIncludes file, for example it is included in LuaEngine.cpp where we use eObjectAccessor() but the cppcheck does not pass because it does not find eObjectAccessor(), and this since before my PR ^^
Original source
![[Image: image.png?ex=690c25c8&is=690ad448&hm=b78...e757c836a&]](https://cdn.discordapp.com/attachments/448835144564867094/1331301386649862245/image.png?ex=690c25c8&is=690ad448&hm=b780620c5eb3f4c59effb68b53821dee0308528e207daca73d2256fe757c836a&)
rektbyfaith
01-21-2025, 04:36 PM #13Archived author: iThorgrim • Posted: 2025-01-21T16:36:24.970000+00:00
Original source
Original source
Same problem
rektbyfaith
01-21-2025, 04:36 PM #14Archived author: iThorgrim • Posted: 2025-01-21T16:36:25.850000+00:00
Original source
Same problem
Original source
Gotcha, I'll merge the reorg
rektbyfaith
01-21-2025, 04:36 PM #15Archived author: Honey • Posted: 2025-01-21T16:36:27.446000+00:00
Original source
Gotcha, I'll merge the reorg
Original source
I think it's good idea to create a new action on mod-eluna for cppcheck
rektbyfaith
01-21-2025, 04:36 PM #16Archived author: iThorgrim • Posted: 2025-01-21T16:36:51.447000+00:00
Original source
I think it's good idea to create a new action on mod-eluna for cppcheck
Original source
because u can specify a files during the cppcheck
rektbyfaith
01-21-2025, 04:37 PM #17Archived author: iThorgrim • Posted: 2025-01-21T16:37:18.861000+00:00
Original source
because u can specify a files during the cppcheck
Original source
We're using re-useable actions currently. There might be a need to change this.
rektbyfaith
01-21-2025, 04:38 PM #18Archived author: Honey • Posted: 2025-01-21T16:38:45.617000+00:00
Original source
We're using re-useable actions currently. There might be a need to change this.
Original source
The idea would be to specify in the cppcheck command that the ElunaIncludes file be taken into consideration
rektbyfaith
01-21-2025, 04:39 PM #19Archived author: iThorgrim • Posted: 2025-01-21T16:39:12.208000+00:00
Original source
The idea would be to specify in the cppcheck command that the ElunaIncludes file be taken into consideration
Original source
I can make the change if possible
rektbyfaith
01-21-2025, 04:39 PM #20Archived author: iThorgrim • Posted: 2025-01-21T16:39:38.264000+00:00
Original source
I can make the change if possible