[DiscordArchive] I patched `Unit:CastSpell()` as follows:
[DiscordArchive] I patched `Unit:CastSpell()` as follows:
Original source
Yeah, that exactly - basically directly use `triggerFlags`, without setting `TRIGGERED_FULL_MASK`
rektbyfaith
01-25-2024, 11:42 AM #11Archived author: tomato • Posted: 2024-01-25T11:42:26.439000+00:00
Original source
Yeah, that exactly - basically directly use `triggerFlags`, without setting `TRIGGERED_FULL_MASK`
Original source
I have a vague feeling the answer involves packets. <:kneecap:1142939447567069184>
rektbyfaith
01-25-2024, 11:43 AM #12Archived author: Honey • Posted: 2024-01-25T11:43:46.552000+00:00
Original source
I have a vague feeling the answer involves packets. <:kneecap:1142939447567069184>
Original source
Then the core side call needs to be changed to allow you to pass through flags
rektbyfaith
01-25-2024, 11:44 AM #13Archived author: Foe • Posted: 2024-01-25T11:44:04.735000+00:00
Original source
Then the core side call needs to be changed to allow you to pass through flags
Original source
And a 4th variable
rektbyfaith
01-25-2024, 11:44 AM #14Archived author: Foe • Posted: 2024-01-25T11:44:10.893000+00:00
Original source
And a 4th variable
Original source
Optional 4th variable it is
rektbyfaith
01-25-2024, 11:44 AM #15Archived author: Honey • Posted: 2024-01-25T11:44:35.409000+00:00
Original source
Optional 4th variable it is
Original source
Yeah, I've done that:
```diff
diff --git a/src/LuaEngine/UnitMethods.h b/src/LuaEngine/UnitMethods.h
index 50e467b..4e06c03 100644
--- a/src/LuaEngine/UnitMethods.h
+++ b/src/LuaEngine/UnitMethods.h
@@ -7,6 +7,8 @@
#ifndef UNITMETHODS_H
#define UNITMETHODS_H
+#include <SpellDefines.h>
+
/***
* Inherits all methods from: [Object], [WorldObject]
*/
@@ -2199,11 +2201,12 @@ namespace LuaUnit
Unit* target = Eluna::CHECKOBJ<Unit>(L, 2, false);
uint32 spell = Eluna::CHECKVAL<uint32>(L, 3);
bool triggered = Eluna::CHECKVAL<bool>(L, 4, false);
+ TriggerCastFlags triggerFlags = (TriggerCastFlags)Eluna::CHECKVAL<uint32>(L, 5, triggered ? TRIGGERED_FULL_MASK : TRIGGERED_NONE); // TODO: terrible cast
SpellInfo const* spellEntry = sSpellMgr->GetSpellInfo(spell);
if (!spellEntry)
return 0;
-
- unit->CastSpell(target, spell, triggered);
+
+ unit->CastSpell(target, spell, triggerFlags);
return 0;
}
```
but `Spell::SendSpellStart()` has a check if any flags in `triggerFlags` are set, and sets `CAST_FLAG_PENDING` if so, suppressing both cast bar and cast start event
rektbyfaith
01-25-2024, 11:45 AM #16Archived author: tomato • Posted: 2024-01-25T11:45:13.768000+00:00
Original source
Yeah, I've done that:
```diff
diff --git a/src/LuaEngine/UnitMethods.h b/src/LuaEngine/UnitMethods.h
index 50e467b..4e06c03 100644
--- a/src/LuaEngine/UnitMethods.h
+++ b/src/LuaEngine/UnitMethods.h
@@ -7,6 +7,8 @@
#ifndef UNITMETHODS_H
#define UNITMETHODS_H
+#include <SpellDefines.h>
+
/***
* Inherits all methods from: [Object], [WorldObject]
*/
@@ -2199,11 +2201,12 @@ namespace LuaUnit
Unit* target = Eluna::CHECKOBJ<Unit>(L, 2, false);
uint32 spell = Eluna::CHECKVAL<uint32>(L, 3);
bool triggered = Eluna::CHECKVAL<bool>(L, 4, false);
+ TriggerCastFlags triggerFlags = (TriggerCastFlags)Eluna::CHECKVAL<uint32>(L, 5, triggered ? TRIGGERED_FULL_MASK : TRIGGERED_NONE); // TODO: terrible cast
SpellInfo const* spellEntry = sSpellMgr->GetSpellInfo(spell);
if (!spellEntry)
return 0;
-
- unit->CastSpell(target, spell, triggered);
+
+ unit->CastSpell(target, spell, triggerFlags);
return 0;
}
```
but `Spell::SendSpellStart()` has a check if any flags in `triggerFlags` are set, and sets `CAST_FLAG_PENDING` if so, suppressing both cast bar and cast start event
Original source
Core side changes it is then
rektbyfaith
01-25-2024, 11:47 AM #17Archived author: Foe • Posted: 2024-01-25T11:47:03.063000+00:00
Original source
Core side changes it is then
1 Guest(s)
1 Guest(s)