Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] Sure, but 3.3k lines?

[DiscordArchive] Sure, but 3.3k lines?

[DiscordArchive] Sure, but 3.3k lines?

Pages (4): 1 2 3 4 Next
rektbyfaith
Administrator
0
02-07-2023, 12:01 AM
#1
Archived author: Bench • Posted: 2023-02-07T00:01:16.878000+00:00
Original source

Sure, but 3.3k lines?
rektbyfaith
02-07-2023, 12:01 AM #1

Archived author: Bench • Posted: 2023-02-07T00:01:16.878000+00:00
Original source

Sure, but 3.3k lines?

rektbyfaith
Administrator
0
02-07-2023, 12:01 AM
#2
Archived author: Nyeriah • Posted: 2023-02-07T00:01:51.747000+00:00
Original source

clean code is always better code
rektbyfaith
02-07-2023, 12:01 AM #2

Archived author: Nyeriah • Posted: 2023-02-07T00:01:51.747000+00:00
Original source

clean code is always better code

rektbyfaith
Administrator
0
02-07-2023, 12:01 AM
#3
Archived author: Nyeriah • Posted: 2023-02-07T00:01:58.755000+00:00
Original source

but this is up to eluna devs not me
rektbyfaith
02-07-2023, 12:01 AM #3

Archived author: Nyeriah • Posted: 2023-02-07T00:01:58.755000+00:00
Original source

but this is up to eluna devs not me

rektbyfaith
Administrator
0
02-07-2023, 12:02 AM
#4
Archived author: Rymercyble • Posted: 2023-02-07T00:02:23.381000+00:00
Original source

3.3k in clion could be issue for ppl with low end pc
rektbyfaith
02-07-2023, 12:02 AM #4

Archived author: Rymercyble • Posted: 2023-02-07T00:02:23.381000+00:00
Original source

3.3k in clion could be issue for ppl with low end pc

rektbyfaith
Administrator
0
02-07-2023, 12:02 AM
#5
Archived author: Nyeriah • Posted: 2023-02-07T00:02:23.771000+00:00
Original source

just pointing out the ton of dead code we have atm
rektbyfaith
02-07-2023, 12:02 AM #5

Archived author: Nyeriah • Posted: 2023-02-07T00:02:23.771000+00:00
Original source

just pointing out the ton of dead code we have atm

rektbyfaith
Administrator
0
02-07-2023, 12:03 AM
#6
Archived author: Honey • Posted: 2023-02-07T00:03:31.386000+00:00
Original source

It's not the first time it comes up, I talked to Roboto about it the other day. But i think currently there are more pressing matters than a potential dead-weight cleanup. At least on my end.
rektbyfaith
02-07-2023, 12:03 AM #6

Archived author: Honey • Posted: 2023-02-07T00:03:31.386000+00:00
Original source

It's not the first time it comes up, I talked to Roboto about it the other day. But i think currently there are more pressing matters than a potential dead-weight cleanup. At least on my end.

rektbyfaith
Administrator
0
02-07-2023, 12:03 AM
#7
Archived author: Foe • Posted: 2023-02-07T00:03:54.048000+00:00
Original source

Oooor
rektbyfaith
02-07-2023, 12:03 AM #7

Archived author: Foe • Posted: 2023-02-07T00:03:54.048000+00:00
Original source

Oooor

rektbyfaith
Administrator
0
02-07-2023, 12:05 AM
#8
Archived author: Foe • Posted: 2023-02-07T00:05:30.079000+00:00
Original source

You could use the proper repository, with the compatibility work I started. This would only include code for your specific emulator, allow you to maintain and add whatever you want yourself, and have it cleaned up with none of the other cores' compatibility code ‍♂️

That said, it doesn't matter once the code is compiled, all the ifdef code is completely ignored in the compiler
rektbyfaith
02-07-2023, 12:05 AM #8

Archived author: Foe • Posted: 2023-02-07T00:05:30.079000+00:00
Original source

You could use the proper repository, with the compatibility work I started. This would only include code for your specific emulator, allow you to maintain and add whatever you want yourself, and have it cleaned up with none of the other cores' compatibility code ‍♂️

That said, it doesn't matter once the code is compiled, all the ifdef code is completely ignored in the compiler

rektbyfaith
Administrator
0
02-07-2023, 12:07 AM
#9
Archived author: Honey • Posted: 2023-02-07T00:07:12.613000+00:00
Original source

I think the last time it came up, the outcome is that nobody is available to port everything. And that we would need to rely on the master maintainers, e.g. when it comes to personal changes here.
rektbyfaith
02-07-2023, 12:07 AM #9

Archived author: Honey • Posted: 2023-02-07T00:07:12.613000+00:00
Original source

I think the last time it came up, the outcome is that nobody is available to port everything. And that we would need to rely on the master maintainers, e.g. when it comes to personal changes here.

rektbyfaith
Administrator
0
02-07-2023, 12:07 AM
#10
Archived author: Foe • Posted: 2023-02-07T00:07:27.744000+00:00
Original source

There's not really a lot of changes you've done
rektbyfaith
02-07-2023, 12:07 AM #10

Archived author: Foe • Posted: 2023-02-07T00:07:27.744000+00:00
Original source

There's not really a lot of changes you've done

Pages (4): 1 2 3 4 Next
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)