[DiscordArchive] I just compiled a fresh pull of AC and mod-eluna. No errors. Can you please provide reproduction ste
[DiscordArchive] I just compiled a fresh pull of AC and mod-eluna. No errors. Can you please provide reproduction ste
Original source
our eluna module is still ehm "polluted" with the compabiility for the other cores
rektbyfaith
02-06-2023, 11:41 PM #11Archived author: Nyeriah • Posted: 2023-02-06T23:41:59.831000+00:00
Original source
our eluna module is still ehm "polluted" with the compabiility for the other cores
Original source
so the reference you updated must be for mangos or something else
rektbyfaith
02-06-2023, 11:42 PM #12Archived author: Nyeriah • Posted: 2023-02-06T23:42:23.569000+00:00
Original source
so the reference you updated must be for mangos or something else
Original source
I'm not sure if we should even keep those, our eluna module most definitely wont compile on other cores with the custom stuff we added (?)
rektbyfaith
02-06-2023, 11:43 PM #13Archived author: Nyeriah • Posted: 2023-02-06T23:43:13.570000+00:00
Original source
I'm not sure if we should even keep those, our eluna module most definitely wont compile on other cores with the custom stuff we added (?)
Original source
Probably shouldn't, it's not like anyone's going to maintain it to compile on other cores
rektbyfaith
02-06-2023, 11:44 PM #14Archived author: Bench • Posted: 2023-02-06T23:44:40.055000+00:00
Original source
Probably shouldn't, it's not like anyone's going to maintain it to compile on other cores
Original source
Even ignoring AC additions
rektbyfaith
02-06-2023, 11:44 PM #15Archived author: Bench • Posted: 2023-02-06T23:44:58.732000+00:00
Original source
Even ignoring AC additions
Original source
yeah I think this one was in the mangos section
![[Image: image.png?ex=690be236&is=690a90b6&hm=17a...61f809884&]](https://cdn.discordapp.com/attachments/448835144564867094/1072302699913154682/image.png?ex=690be236&is=690a90b6&hm=17af35f2209aacc60284ed973229c224025c55dd10b8104658417f061f809884&)
rektbyfaith
02-06-2023, 11:48 PM #16Archived author: Nyeriah • Posted: 2023-02-06T23:48:06.149000+00:00
Original source
yeah I think this one was in the mangos section
Original source
couldn't find the if/elseif that led to it though
rektbyfaith
02-06-2023, 11:48 PM #17Archived author: Nyeriah • Posted: 2023-02-06T23:48:21.490000+00:00
Original source
couldn't find the if/elseif that led to it though
Original source
maybe this
![[Image: image.png?ex=690be26f&is=690a90ef&hm=15e...1abf8e5d5&]](https://cdn.discordapp.com/attachments/448835144564867094/1072302940364218408/image.png?ex=690be26f&is=690a90ef&hm=15e64a3f778585165f908af0fa3aa3c678a174df76026bf364778f91abf8e5d5&)
rektbyfaith
02-06-2023, 11:49 PM #18Archived author: Nyeriah • Posted: 2023-02-06T23:49:03.447000+00:00
Original source
maybe this
Original source
I don't think it does compile. I also don't think anyone would port our additions. I'm not against the removal of any code strictly for other cores. But i don't see the harm in keeping it. It doesn't even run through the compiler. And if somebody can make use of it some day, why not let it stay.
We can also keep the list of commits in the readme.
rektbyfaith
02-06-2023, 11:57 PM #19Archived author: Honey • Posted: 2023-02-06T23:57:06.336000+00:00
Original source
I don't think it does compile. I also don't think anyone would port our additions. I'm not against the removal of any code strictly for other cores. But i don't see the harm in keeping it. It doesn't even run through the compiler. And if somebody can make use of it some day, why not let it stay.
We can also keep the list of commits in the readme.
Original source
the only harm it does is bloat files, GlobalFunctions has 3,3k lines when we probably only need a few short of 1k
rektbyfaith
02-06-2023, 11:58 PM #20Archived author: Nyeriah • Posted: 2023-02-06T23:58:06.776000+00:00
Original source
the only harm it does is bloat files, GlobalFunctions has 3,3k lines when we probably only need a few short of 1k
1 Guest(s)
1 Guest(s)