[DiscordArchive] So https://github.com/azerothcore/azerothcore-wotlk/pull/2858 is updating the name from spawndist to
[DiscordArchive] So https://github.com/azerothcore/azerothcore-wotlk/pull/2858 is updating the name from spawndist to
Original source
So https://github.com/azerothcore/azerothco.../pull/2858 is updating the name from spawndist to wander_distance in `creature` like trinitycore.
and we get this error
```
/home/travis/build/azerothcore/azerothcore-wotlk/modules/mod-eluna-lua-engine/LuaEngine/CreatureMethods.h:429:34: fatal error: no member named 'GetRespawnRadius' in 'Creature'; did you mean 'GetRespawnTime'?
```
I suppose
```diff
CreatureMethods.h L#426
int GetWanderRadius(lua_State* L, Creature* creature)
{
- #ifdef TRINITY
+ #if defined TRINITY || AZEROTHCORE
Eluna:
ush(L, creature->GetWanderDistance());#else
Eluna:
ush(L, creature->GetRespawnRadius());#endif
return 1;
}
```
in Eluna would fix that error?
[Embed: fix(Core/Creature): Use proper name for wander distance by Kitzunu ...]
Co-Authored-By: ratkosrb ratkosrb@users.noreply.github.com
Cherry-picked from TrinityCore/TrinityCore@6176ce9 and a bit modified for acore.
CHANGES PROPOSED:
Change spawndist to wander_distance ...
https://github.com/azerothcore/azerothco.../pull/2858
rektbyfaith
04-09-2020, 05:46 PM #1Archived author: Kitzunu • Posted: 2020-04-09T17:46:53.105000+00:00
Original source
So https://github.com/azerothcore/azerothco.../pull/2858 is updating the name from spawndist to wander_distance in `creature` like trinitycore.
and we get this error
```
/home/travis/build/azerothcore/azerothcore-wotlk/modules/mod-eluna-lua-engine/LuaEngine/CreatureMethods.h:429:34: fatal error: no member named 'GetRespawnRadius' in 'Creature'; did you mean 'GetRespawnTime'?
```
I suppose
```diff
CreatureMethods.h L#426
int GetWanderRadius(lua_State* L, Creature* creature)
{
- #ifdef TRINITY
+ #if defined TRINITY || AZEROTHCORE
Eluna:ush(L, creature->GetWanderDistance());
#else
Eluna:ush(L, creature->GetRespawnRadius());
#endif
return 1;
}
```
in Eluna would fix that error?
[Embed: fix(Core/Creature): Use proper name for wander distance by Kitzunu ...]
Co-Authored-By: ratkosrb ratkosrb@users.noreply.github.com
Cherry-picked from TrinityCore/TrinityCore@6176ce9 and a bit modified for acore.
CHANGES PROPOSED:
Change spawndist to wander_distance ...
https://github.com/azerothcore/azerothco.../pull/2858
Original source
Hmm, sure.
One way is to make a PR and wait for it to merge.
Another is to make a fork, do changes there and use it instead, and maybe make a PR and maybe once PR is merged change back to original repo.
rektbyfaith
04-09-2020, 05:49 PM #2Archived author: Rochet2 • Posted: 2020-04-09T17:49:16.905000+00:00
Original source
Hmm, sure.
One way is to make a PR and wait for it to merge.
Another is to make a fork, do changes there and use it instead, and maybe make a PR and maybe once PR is merged change back to original repo.
Original source
<-- dont use Eluna myself, I am just trying to fix the error on main AC Repo ♂️
What do you think is the best approach for it? Make a PR on Eluna and just wait with the AC one until the one on Eluna is merged?
rektbyfaith
04-09-2020, 05:50 PM #3Archived author: Kitzunu • Posted: 2020-04-09T17:50:56.639000+00:00
Original source
<-- dont use Eluna myself, I am just trying to fix the error on main AC Repo ♂️
What do you think is the best approach for it? Make a PR on Eluna and just wait with the AC one until the one on Eluna is merged?
Original source
y, that is one way
rektbyfaith
04-09-2020, 05:51 PM #4Archived author: Rochet2 • Posted: 2020-04-09T17:51:14.676000+00:00
Original source
y, that is one way
Original source
ok Imma go for that then
rektbyfaith
04-09-2020, 05:53 PM #5Archived author: Kitzunu • Posted: 2020-04-09T17:53:48.942000+00:00
Original source
ok Imma go for that then
Original source
Thank you!
rektbyfaith
04-09-2020, 05:53 PM #6Archived author: Kitzunu • Posted: 2020-04-09T17:53:51.134000+00:00
Original source
Thank you!
1 Guest(s)
1 Guest(s)