[DiscordArchive] When fixing a smart script should I include the entire smart script in the PR or only the part where
[DiscordArchive] When fixing a smart script should I include the entire smart script in the PR or only the part where
Original source
When fixing a smart script should I include the entire smart script in the PR or only the part where it was changed?
rektbyfaith
11-28-2023, 08:03 PM #1Archived author: swagkhalifa • Posted: 2023-11-28T20:03:35.442000+00:00
Original source
When fixing a smart script should I include the entire smart script in the PR or only the part where it was changed?
Original source
Depends on the PR, really. You should go with your gut.
If it's only an UPDATE change you can do whatever. If it only adds one or two lines you can just change those.
Doing the entire thing is easier to read, though. Especially if it contains linked events.
rektbyfaith
11-28-2023, 08:31 PM #2Archived author: Gultask • Posted: 2023-11-28T20:31:05.620000+00:00
Original source
Depends on the PR, really. You should go with your gut.
If it's only an UPDATE change you can do whatever. If it only adds one or two lines you can just change those.
Doing the entire thing is easier to read, though. Especially if it contains linked events.
Original source
tldr there's no standing rule, just do what feels right
rektbyfaith
11-28-2023, 08:31 PM #3Archived author: Gultask • Posted: 2023-11-28T20:31:29.861000+00:00
Original source
tldr there's no standing rule, just do what feels right
Original source
Dang he's really back
rektbyfaith
11-28-2023, 08:32 PM #4Archived author: Bench • Posted: 2023-11-28T20:32:44.919000+00:00
Original source
Dang he's really back
1 Guest(s)
1 Guest(s)