[DiscordArchive] maybe make an initial PR, mark it as WIP (can do that for you) and we can review from there?
[DiscordArchive] maybe make an initial PR, mark it as WIP (can do that for you) and we can review from there?
Original source
maybe make an initial PR, mark it as WIP (can do that for you) and we can review from there?
rektbyfaith
10-05-2021, 06:23 PM #1Archived author: Drooppi • Posted: 2021-10-05T18:23:46.214000+00:00
Original source
maybe make an initial PR, mark it as WIP (can do that for you) and we can review from there?
Original source
cool I'll do that later today prolly, got an appointment in a few
rektbyfaith
10-05-2021, 06:28 PM #2Archived author: Neifion • Posted: 2021-10-05T18:28:44.270000+00:00
Original source
cool I'll do that later today prolly, got an appointment in a few
Original source
However it sounds more like a core issue that you're hackfixing through the DB, shouldn't the patrol simply respawn eventually and "regroup" ?
rektbyfaith
10-05-2021, 06:29 PM #3Archived author: Drooppi • Posted: 2021-10-05T18:29:06.170000+00:00
Original source
However it sounds more like a core issue that you're hackfixing through the DB, shouldn't the patrol simply respawn eventually and "regroup" ?
Original source
but once there's a PR we can have a clearer view on what's happening
rektbyfaith
10-05-2021, 06:29 PM #4Archived author: Drooppi • Posted: 2021-10-05T18:29:28.332000+00:00
Original source
but once there's a PR we can have a clearer view on what's happening
Original source
the patrol will eventually fix itself, but the expected behavior if you kill 1 mob and run off is the patrol should just keep walking without the mob that died
rektbyfaith
10-05-2021, 06:29 PM #5Archived author: Neifion • Posted: 2021-10-05T18:29:32.952000+00:00
Original source
the patrol will eventually fix itself, but the expected behavior if you kill 1 mob and run off is the patrol should just keep walking without the mob that died
Original source
Maybe a "leadership swap" could be a better solution then, because there's a lot of patrols in the world, anyway, let's see your proposal and review that
rektbyfaith
10-05-2021, 06:30 PM #6Archived author: Drooppi • Posted: 2021-10-05T18:30:33.035000+00:00
Original source
Maybe a "leadership swap" could be a better solution then, because there's a lot of patrols in the world, anyway, let's see your proposal and review that
Original source
there's also a second problem but I don't have enough blizzard footage yet for it, when a mob respawns it should respawn into the group at the location of the patrol wherever that may be, which leads me to believe the waypoint isn't completely wrong tbh (whatever blizzard does might not be a waypoint creature, but its something done invisibly that keeps track of where the patrol should be)
rektbyfaith
10-05-2021, 06:32 PM #7Archived author: Neifion • Posted: 2021-10-05T18:32:36.165000+00:00
Original source
there's also a second problem but I don't have enough blizzard footage yet for it, when a mob respawns it should respawn into the group at the location of the patrol wherever that may be, which leads me to believe the waypoint isn't completely wrong tbh (whatever blizzard does might not be a waypoint creature, but its something done invisibly that keeps track of where the patrol should be)
Original source
because it explains why a patrol might not spawn at the same location every time
rektbyfaith
10-05-2021, 06:33 PM #8Archived author: Neifion • Posted: 2021-10-05T18:33:01.963000+00:00
Original source
because it explains why a patrol might not spawn at the same location every time
Original source
the second problem can't be fixed with just SQL tho, so I wasn't addressing that; I want to learn c++ but that seems a bit more complicated than a starter bug for that
rektbyfaith
10-05-2021, 06:33 PM #9Archived author: Neifion • Posted: 2021-10-05T18:33:12.209000+00:00
Original source
the second problem can't be fixed with just SQL tho, so I wasn't addressing that; I want to learn c++ but that seems a bit more complicated than a starter bug for that
Original source
This sounds like the main reason it isn't working otherwise is because of missing core features? If thats the case the proper way would probably be to submit a feature request for a certain mechanic if its missing and then work your PR around that.
If your way to fix things is another hackfix which just goes around the issue then it might have some problems getting merged.
rektbyfaith
10-05-2021, 10:43 PM #10Archived author: Hacki • Posted: 2021-10-05T22:43:02.867000+00:00
Original source
This sounds like the main reason it isn't working otherwise is because of missing core features? If thats the case the proper way would probably be to submit a feature request for a certain mechanic if its missing and then work your PR around that.
If your way to fix things is another hackfix which just goes around the issue then it might have some problems getting merged.
1 Guest(s)
1 Guest(s)