[DiscordArchive] If you've really got that much code, it'll definitely take folks a long time to review it. Maybe sta
[DiscordArchive] If you've really got that much code, it'll definitely take folks a long time to review it. Maybe sta
Original source
If you've really got that much code, it'll definitely take folks a long time to review it. Maybe start with 1 or 2 PRs and go from there?
rektbyfaith
02-04-2021, 12:19 AM #1Archived author: steen • Posted: 2021-02-04T00:19:41.722000+00:00
Original source
If you've really got that much code, it'll definitely take folks a long time to review it. Maybe start with 1 or 2 PRs and go from there?
Original source
Then you can adjust your queries based on feedback from other folks and you won't have to re-make every single PR if a major change is requested. It'll also get you used to making a PR to AZCore, and things will go more smoothly for future PRs.
rektbyfaith
02-04-2021, 12:21 AM #2Archived author: steen • Posted: 2021-02-04T00:21:15.357000+00:00
Original source
Then you can adjust your queries based on feedback from other folks and you won't have to re-make every single PR if a major change is requested. It'll also get you used to making a PR to AZCore, and things will go more smoothly for future PRs.
Original source
Sure can do : )
rektbyfaith
02-04-2021, 12:25 AM #3Archived author: Robert • Posted: 2021-02-04T00:25:32.793000+00:00
Original source
Sure can do : )
Original source
Question regarding fixing in-game things (DB wise) that are reported. Do i need to submit a PR for those as well?
- https://github.com/azerothcore/azerothco...ssues/4424 this one as an example.
[Embed: Double stacked veins in Stranglethorn Vale next to Booty Bay · Issu...]
Double stacked veins in Stranglethorn Vale next to Booty Bay CURRENT BEHAVIOUR: EXPECTED BLIZZLIKE BEHAVIOUR: Usually don't encounter 2 veins inside of eachother Blizzlike. STEPS TO REPRODU...
https://github.com/azerothcore/azerothco...ssues/4424
rektbyfaith
02-04-2021, 12:27 AM #4Archived author: Robert • Posted: 2021-02-04T00:27:22.718000+00:00
Original source
Question regarding fixing in-game things (DB wise) that are reported. Do i need to submit a PR for those as well?
- https://github.com/azerothcore/azerothco...ssues/4424 this one as an example.
[Embed: Double stacked veins in Stranglethorn Vale next to Booty Bay · Issu...]
Double stacked veins in Stranglethorn Vale next to Booty Bay CURRENT BEHAVIOUR: EXPECTED BLIZZLIKE BEHAVIOUR: Usually don't encounter 2 veins inside of eachother Blizzlike. STEPS TO REPRODU...
https://github.com/azerothcore/azerothco...ssues/4424
Original source
There is a guide how to provide DB pr's.
It includes a bash script which creates a unique file name. Can't find the Link in my phone.
rektbyfaith
02-04-2021, 12:33 AM #5Archived author: Honey • Posted: 2021-02-04T00:33:47.299000+00:00
Original source
There is a guide how to provide DB pr's.
It includes a bash script which creates a unique file name. Can't find the Link in my phone.
Original source
exactly, it's all explained in https://www.azerothcore.org/wiki/How-to-create-a-PR
[Embed: How to create a PR]
Wiki and Documentation of AzerothCore project
https://www.azerothcore.org/wiki/How-to-create-a-PR
rektbyfaith
02-04-2021, 01:07 AM #6Archived author: Shin • Posted: 2021-02-04T01:07:12.219000+00:00
Original source
exactly, it's all explained in https://www.azerothcore.org/wiki/How-to-create-a-PR
[Embed: How to create a PR]
Wiki and Documentation of AzerothCore project
https://www.azerothcore.org/wiki/How-to-create-a-PR
Original source
ok, also big PRs can be accepted but ideally you should divide and group them in a way that's easier for testers to check them
rektbyfaith
02-04-2021, 01:08 AM #7Archived author: Shin • Posted: 2021-02-04T01:08:01.111000+00:00
Original source
ok, also big PRs can be accepted but ideally you should divide and group them in a way that's easier for testers to check them
Original source
Ohh i document my work quite nicely within my querries. so grouping and or categorizing should not be a problem.
rektbyfaith
02-04-2021, 01:08 AM #8Archived author: Robert • Posted: 2021-02-04T01:08:38.177000+00:00
Original source
Ohh i document my work quite nicely within my querries. so grouping and or categorizing should not be a problem.
Original source
awesome!
rektbyfaith
02-04-2021, 01:08 AM #9Archived author: Shin • Posted: 2021-02-04T01:08:51.028000+00:00
Original source
awesome!
Original source
Just as a follow-up to this, turns out I'm just dumb. I deleted the wrong condition from the table, which is why I was seeing unexpected results. I fixed this, restarted the server and yes, yes the server does read the conditions table just like any other table. Nothing weird there.
rektbyfaith
02-04-2021, 01:09 AM #10Archived author: steen • Posted: 2021-02-04T01:09:59.085000+00:00
Original source
Just as a follow-up to this, turns out I'm just dumb. I deleted the wrong condition from the table, which is why I was seeing unexpected results. I fixed this, restarted the server and yes, yes the server does read the conditions table just like any other table. Nothing weird there.
1 Guest(s)
1 Guest(s)