[DiscordArchive] Just out of curiosity, why haven't these been updated for the modules (on your own git) together wit
[DiscordArchive] Just out of curiosity, why haven't these been updated for the modules (on your own git) together wit
Original source
Interesting, as it looks like OnLogin should have been modified to OnPlayerLogin?
rektbyfaith
02-24-2025, 05:32 PM #11Archived author: nl-saw • Posted: 2025-02-24T17:32:36.041000+00:00
Original source
Interesting, as it looks like OnLogin should have been modified to OnPlayerLogin?
Original source
only 3 changes
line 66: void OnLogin(Player* player) override
line 104: void OnLogout(Player* player) override
line 112: void OnGiveXP(Player* player, uint32& amount, Unit* /victim/, uint8 /xpSource/) override
rektbyfaith
02-24-2025, 05:34 PM #12Archived author: iDizoxx • Posted: 2025-02-24T17:34:53.403000+00:00
Original source
only 3 changes
line 66: void OnLogin(Player* player) override
line 104: void OnLogout(Player* player) override
line 112: void OnGiveXP(Player* player, uint32& amount, Unit* /victim/, uint8 /xpSource/) override
Original source
https://tenor.com/view/negan-negan-smith...f-26236761
rektbyfaith
02-24-2025, 05:35 PM #13Archived author: iDizoxx • Posted: 2025-02-24T17:35:11.048000+00:00
Original source
https://tenor.com/view/negan-negan-smith...f-26236761
Original source
rektbyfaith
02-24-2025, 05:35 PM #14Archived author: iDizoxx • Posted: 2025-02-24T17:35:13.201000+00:00
Original source
Original source
Hehe, what I mean is that in your fixed code, void OnLogin(Player* player) override is still only OnLogin, whereas it seems that should have moved to OnPlayerLogin, as you changed for the other two you mentioned. So I am surprised that it works, is all.
rektbyfaith
02-24-2025, 05:38 PM #15Archived author: nl-saw • Posted: 2025-02-24T17:38:14.534000+00:00
Original source
Hehe, what I mean is that in your fixed code, void OnLogin(Player* player) override is still only OnLogin, whereas it seems that should have moved to OnPlayerLogin, as you changed for the other two you mentioned. So I am surprised that it works, is all.
Original source
hmm, maybe I pull the wrong part, hold on
rektbyfaith
02-24-2025, 05:38 PM #16Archived author: iDizoxx • Posted: 2025-02-24T17:38:51.239000+00:00
Original source
hmm, maybe I pull the wrong part, hold on
Original source
u r right
rektbyfaith
02-24-2025, 05:41 PM #17Archived author: iDizoxx • Posted: 2025-02-24T17:41:30.880000+00:00
Original source
u r right
Original source
ma bad
rektbyfaith
02-24-2025, 05:41 PM #18Archived author: iDizoxx • Posted: 2025-02-24T17:41:32.735000+00:00
Original source
ma bad
Original source
edited on github
rektbyfaith
02-24-2025, 05:42 PM #19Archived author: iDizoxx • Posted: 2025-02-24T17:42:22.060000+00:00
Original source
edited on github
Original source
I'm interested in knowing what you are referring to and what the common (ab)use for it is currently? Also as many mods probalby need a tweak, this could be your window of opportunity, hehe
rektbyfaith
02-24-2025, 05:51 PM #20Archived author: nl-saw • Posted: 2025-02-24T17:51:39.111000+00:00
Original source
I'm interested in knowing what you are referring to and what the common (ab)use for it is currently? Also as many mods probalby need a tweak, this could be your window of opportunity, hehe
1 Guest(s)
1 Guest(s)