[DiscordArchive] Just out of curiosity, why haven't these been updated for the modules (on your own git) together wit
[DiscordArchive] Just out of curiosity, why haven't these been updated for the modules (on your own git) together wit
Archived author: nl-saw • Posted: 2025-02-24T16:22:51.057000+00:00
Original source
Just out of curiosity, why haven't these been updated for the modules (on your own git) together with those changes?
Archived author: Ryan Turner • Posted: 2025-02-24T16:23:25.201000+00:00
Original source
If you've tested that itworks on compiling, be free to submit a PR
Archived author: iDizoxx • Posted: 2025-02-24T16:23:38.216000+00:00
Original source
compiling now
Archived author: Nyeriah • Posted: 2025-02-24T16:24:37.150000+00:00
Original source
I don’t understand the question
Archived author: Ryan Turner • Posted: 2025-02-24T16:24:45.276000+00:00
Original source
Because is impossible to fix every module before a major change happens. And maintaining of the core and their modules doesn't fall exclusive under the team, it's collective work of contribuitors
Archived author: iDizoxx • Posted: 2025-02-24T16:36:21.290000+00:00
Original source
It works!
Archived author: iDizoxx • Posted: 2025-02-24T16:42:56.577000+00:00
Original source
but when trying to add new PR: Pull request creation failed. Validation failed: must be a collaborator
Archived author: Ryan Turner • Posted: 2025-02-24T16:47:38.681000+00:00
Original source
Because it has to validated by the staff otherwise anyone could merge their changes
Archived author: iDizoxx • Posted: 2025-02-24T16:50:04.320000+00:00
Original source
okay, so here is updated if anyone need: https://github.com/iDizoxx/individual-xp...thcore-fix
[Embed: GitHub - iDizoxx/individual-xp-rate-azerothcore-fix: Fix for mod-in...]
Fix for mod-individual-xp due to new azerothcore updates. - iDizoxx/individual-xp-rate-azerothcore-fix
https://github.com/iDizoxx/individual-xp...thcore-fix
Archived author: Takenbacon • Posted: 2025-02-24T17:07:03.712000+00:00
Original source
you have no idea how tempted I am to rename ConfigMgr so people stop using it, but at the same time I'd rather not brick almost every module