[DiscordArchive] anything important happened since modelid change ?
[DiscordArchive] anything important happened since modelid change ?
Archived author: Nyeriah • Posted: 2024-08-31T23:19:40.322000+00:00
Original source
but this != player wasnt changed to !IsPlayer()
Archived author: Rymercyble • Posted: 2024-08-31T23:25:21.717000+00:00
Original source
i just thought it was weird that not all were changed
Archived author: Rymercyble • Posted: 2024-08-31T23:25:46.979000+00:00
Original source
so u are saying i probably should manually change all of that to prevent future conflicts
Archived author: Nyeriah • Posted: 2024-08-31T23:33:01.873000+00:00
Original source
the opposite
Archived author: Nyeriah • Posted: 2024-08-31T23:33:17.541000+00:00
Original source
they'll likely change it in the future anyway
Archived author: Nyeriah • Posted: 2024-08-31T23:33:22.216000+00:00
Original source
<@224931509046345729> loves those things
Archived author: Rymercyble • Posted: 2024-08-31T23:33:44.407000+00:00
Original source
i meant changing all TYPEID_PLAYER to IsPlayer()
Archived author: Natrist • Posted: 2024-09-01T04:23:33.641000+00:00
Original source
The worst part for me was looking at those changes and seeing whoever sent in that PR changed occurrences in some of statements and missed some in those very same statements lol
Archived author: Natrist • Posted: 2024-09-01T04:23:46.106000+00:00
Original source
To be fair that is exactly the kind of work AC needs
Archived author: Natrist • Posted: 2024-09-01T04:23:57.012000+00:00
Original source
I applaud the work of that contributor