[DiscordArchive] anything important happened since modelid change ?
[DiscordArchive] anything important happened since modelid change ?
Archived author: Tereneckla • Posted: 2024-08-31T22:18:03.703000+00:00
Original source
38 changes 764 conflicts
Archived author: Revision • Posted: 2024-08-31T22:25:22.731000+00:00
Original source
That's your choice though, so no complaining.
Archived author: Rymercyble • Posted: 2024-08-31T22:28:08.579000+00:00
Original source
most of them are like "IsPlayer()" but its in block which i no longer have but its flagged as conflict anyway
Archived author: Rymercyble • Posted: 2024-08-31T22:28:49.933000+00:00
Original source
would be nice if git was more intelligent about it
Archived author: Rymercyble • Posted: 2024-08-31T22:41:07.553000+00:00
Original source
3400 lines long conflict <:kek:1065379143887372398> thats record for me
Archived author: Rymercyble • Posted: 2024-08-31T22:50:33.204000+00:00
Original source
so some1 was changing TYPEID_PLAYER to IsPlayer() but didnt change it in all places ?
Archived author: Revision • Posted: 2024-08-31T23:10:35.953000+00:00
Original source
It doesn't need to be changed but looking at the history it should be or eventually you'll get screwed when the TYPEID_PLAYER way is no longer supported, just like other things before this.
Archived author: Nyeriah • Posted: 2024-08-31T23:18:20.872000+00:00
Original source
new prs wont accept the old check, it was added to the codestyle ci
Archived author: Nyeriah • Posted: 2024-08-31T23:19:15.672000+00:00
Original source
they removed the positive check but forgot to remove the negation
Archived author: Nyeriah • Posted: 2024-08-31T23:19:26.561000+00:00
Original source
so this == player was changed to IsPlayer()