[DiscordArchive] Regarding code style and other checks, maybe it's better to use a specialized tool for that? I just
[DiscordArchive] Regarding code style and other checks, maybe it's better to use a specialized tool for that? I just
Original source
I know I'm no maintainer and my opinion doesn't mean much, but the big concern is that either it's simple/intuitive enough to be able to be picked up by someone new *or* that the checks we're interested in (at least the bulk of them) can be added with the initial application or very close to it
rektbyfaith
08-18-2024, 08:58 PM #11Archived author: Bench • Posted: 2024-08-18T20:58:31.401000+00:00
Original source
I know I'm no maintainer and my opinion doesn't mean much, but the big concern is that either it's simple/intuitive enough to be able to be picked up by someone new *or* that the checks we're interested in (at least the bulk of them) can be added with the initial application or very close to it
Original source
Because I'm quite concerned that the people driving this project would disappear and it's too complex for someone new to try to revive it and it dies and needs to be gotten rid of
rektbyfaith
08-18-2024, 08:59 PM #12Archived author: Bench • Posted: 2024-08-18T20:59:22.352000+00:00
Original source
Because I'm quite concerned that the people driving this project would disappear and it's too complex for someone new to try to revive it and it dies and needs to be gotten rid of
Original source
This goes for any solution really, not just coala
rektbyfaith
08-18-2024, 09:01 PM #13Archived author: Bench • Posted: 2024-08-18T21:01:23.613000+00:00
Original source
This goes for any solution really, not just coala
Original source
keeping dependencies low is always a valid strat
rektbyfaith
08-18-2024, 09:03 PM #14Archived author: ceikry • Posted: 2024-08-18T21:03:07.399000+00:00
Original source
keeping dependencies low is always a valid strat
Original source
Oh, I just checked their main repo and it seems that it's abandoned So that's a no-go and you shouldn't worry about it
rektbyfaith
08-18-2024, 09:32 PM #15Archived author: walkline • Posted: 2024-08-18T21:32:06.238000+00:00
Original source
Oh, I just checked their main repo and it seems that it's abandoned So that's a no-go and you shouldn't worry about it
Original source
<:blame_kitzunu:1254703013516410890>
rektbyfaith
08-18-2024, 09:38 PM #16Archived author: Kitzunu • Posted: 2024-08-18T21:38:44.030000+00:00
Original source
<:blame_kitzunu:1254703013516410890>
Original source
I really should swap pfp
rektbyfaith
08-18-2024, 09:38 PM #17Archived author: Kitzunu • Posted: 2024-08-18T21:38:55.321000+00:00
Original source
I really should swap pfp
Original source
It's interesting (I love the oportunity to ignoring code inside files, it's avoid to skip all the code from a file), but there are questions about how to maintain it. After that, the advantage is that python is probably better understood by most people than bash. I'll look at the details later, but after that it's mainly a choice for the AC team.
However, for now tests are still too simple and there aren't enough of them to require to abandon the bash script. The best thing would be to share the proposal here, just to keep track : https://github.com/azerothcore/azerothco...sues/19670
rektbyfaith
08-18-2024, 09:39 PM #18Archived author: Deleted User • Posted: 2024-08-18T21:39:17.801000+00:00
Original source
It's interesting (I love the oportunity to ignoring code inside files, it's avoid to skip all the code from a file), but there are questions about how to maintain it. After that, the advantage is that python is probably better understood by most people than bash. I'll look at the details later, but after that it's mainly a choice for the AC team.
However, for now tests are still too simple and there aren't enough of them to require to abandon the bash script. The best thing would be to share the proposal here, just to keep track : https://github.com/azerothcore/azerothco...sues/19670
Original source
I vote c++ tool
No but fr, I dont mind, as long as checks are done thats the important thing
rektbyfaith
08-18-2024, 09:41 PM #19Archived author: Kitzunu • Posted: 2024-08-18T21:41:28.895000+00:00
Original source
I vote c++ tool
No but fr, I dont mind, as long as checks are done thats the important thing
Original source
Long way of saying some other maintainer's problem
rektbyfaith
08-18-2024, 09:41 PM #20Archived author: Bench • Posted: 2024-08-18T21:41:54.926000+00:00
Original source
Long way of saying some other maintainer's problem