[DiscordArchive] <@251803844307189761> any information about the context of crash (to test if to move GlobalCooldown
[DiscordArchive] <@251803844307189761> any information about the context of crash (to test if to move GlobalCooldown
Original source
<@251803844307189761> any information about the context of crash (to test if to move GlobalCooldown work or I need to revert all CharmInfo part) ?
rektbyfaith
08-15-2024, 06:01 PM #1Archived author: Deleted User • Posted: 2024-08-15T18:01:51.391000+00:00
Original source
<@251803844307189761> any information about the context of crash (to test if to move GlobalCooldown work or I need to revert all CharmInfo part) ?
Original source
its a crash from chromiecraft PTR, it has happened 5 times in a row, unfortunately I don`t have more context to give since it could've been caused by anyone online around that time
rektbyfaith
08-15-2024, 06:06 PM #2Archived author: Nyeriah • Posted: 2024-08-15T18:06:23.017000+00:00
Original source
its a crash from chromiecraft PTR, it has happened 5 times in a row, unfortunately I don`t have more context to give since it could've been caused by anyone online around that time
Original source
https://tenor.com/view/bowfinger-eddie-m...if-4444756
[Embed: Ugh... (Eddie Murphy side eye edition)]
https://tenor.com/view/bowfinger-eddie-m...if-4444756
rektbyfaith
08-15-2024, 06:11 PM #3Archived author: Revision • Posted: 2024-08-15T18:11:27.664000+00:00
Original source
https://tenor.com/view/bowfinger-eddie-m...if-4444756
[Embed: Ugh... (Eddie Murphy side eye edition)]
https://tenor.com/view/bowfinger-eddie-m...if-4444756
Original source
Ok, GlobalCooldown class is just linked to CharmInfo and some class for little usage so normaly there are any risk to just move the class if we want to keep "CharmInfo" file. But I will also prepare another PR that revert this part and if it happens again, just merge the revert. I done this quickly.
rektbyfaith
08-15-2024, 06:12 PM #4Archived author: Deleted User • Posted: 2024-08-15T18:12:55.548000+00:00
Original source
Ok, GlobalCooldown class is just linked to CharmInfo and some class for little usage so normaly there are any risk to just move the class if we want to keep "CharmInfo" file. But I will also prepare another PR that revert this part and if it happens again, just merge the revert. I done this quickly.
Original source
Ok done, I test this in local and if it's look fine I push the fix.
rektbyfaith
08-15-2024, 06:15 PM #5Archived author: Deleted User • Posted: 2024-08-15T18:15:38.257000+00:00
Original source
Ok done, I test this in local and if it's look fine I push the fix.
Original source
<@251803844307189761> I found a crash situation on master which I've just tested again with the fix and it's solved. You can probably merge the PR. I'm sorry for the issue
rektbyfaith
08-15-2024, 06:49 PM #6Archived author: Deleted User • Posted: 2024-08-15T18:49:15.179000+00:00
Original source
<@251803844307189761> I found a crash situation on master which I've just tested again with the fix and it's solved. You can probably merge the PR. I'm sorry for the issue
Original source
~~Could a maintainer please add the "run-build" label to this PR - https://github.com/azerothcore/azerothco...pull/19634 ?~~Done
rektbyfaith
08-15-2024, 09:06 PM #7Archived author: walkline • Posted: 2024-08-15T21:06:10.547000+00:00
Original source
~~Could a maintainer please add the "run-build" label to this PR - https://github.com/azerothcore/azerothco...pull/19634 ?~~Done