[DiscordArchive] tbf, im not v familiar w open source etiquette and formats (ive just been eidting stuff on my own pr
[DiscordArchive] tbf, im not v familiar w open source etiquette and formats (ive just been eidting stuff on my own pr
Original source
tbf, im not v familiar w open source etiquette and formats (ive just been eidting stuff on my own private server when the mod authors are MIA on issues) but happy to learn. what does "progress on github" look like for opnesource? do i fork the mod and then push changes to my own fork (if so, how do these changes get pushed all the way up to the azeroth core official mod)?
rektbyfaith
05-14-2024, 02:31 PM #1Archived author: tofuwater • Posted: 2024-05-14T14:31:49.188000+00:00
Original source
tbf, im not v familiar w open source etiquette and formats (ive just been eidting stuff on my own private server when the mod authors are MIA on issues) but happy to learn. what does "progress on github" look like for opnesource? do i fork the mod and then push changes to my own fork (if so, how do these changes get pushed all the way up to the azeroth core official mod)?
Original source
Yes you take your fork, create a new branch and push the changes there
rektbyfaith
05-14-2024, 02:32 PM #2Archived author: sudlud • Posted: 2024-05-14T14:32:19.452000+00:00
Original source
Yes you take your fork, create a new branch and push the changes there
Original source
Then there’s a button on GitHub to create a PR for the module
rektbyfaith
05-14-2024, 02:32 PM #3Archived author: sudlud • Posted: 2024-05-14T14:32:39.769000+00:00
Original source
Then there’s a button on GitHub to create a PR for the module
Original source
Usually you try to fix one issue at a time per branch
rektbyfaith
05-14-2024, 02:33 PM #4Archived author: sudlud • Posted: 2024-05-14T14:33:38.300000+00:00
Original source
Usually you try to fix one issue at a time per branch
Original source
It's part of the sanity checking of characters
rektbyfaith
05-14-2024, 02:35 PM #5Archived author: Foe • Posted: 2024-05-14T14:35:44.458000+00:00
Original source
It's part of the sanity checking of characters
Original source
So it's not a mod issue, it's part of the core sanity checking
rektbyfaith
05-14-2024, 02:36 PM #6Archived author: Foe • Posted: 2024-05-14T14:36:10.278000+00:00
Original source
So it's not a mod issue, it's part of the core sanity checking
Original source
ah okay, got it. i did this once before w the racial swap mod, but wasnt sure if it was different for the other "official" mods or the base game itself
rektbyfaith
05-14-2024, 02:36 PM #7Archived author: tofuwater • Posted: 2024-05-14T14:36:16.023000+00:00
Original source
ah okay, got it. i did this once before w the racial swap mod, but wasnt sure if it was different for the other "official" mods or the base game itself
Original source
It’s generally always like this when working on open source projects on GitHub
rektbyfaith
05-14-2024, 02:36 PM #8Archived author: sudlud • Posted: 2024-05-14T14:36:37.585000+00:00
Original source
It’s generally always like this when working on open source projects on GitHub
Original source
But AC core will not accept any custom non-blizzlike changes of course
rektbyfaith
05-14-2024, 02:36 PM #9Archived author: sudlud • Posted: 2024-05-14T14:36:50.761000+00:00
Original source
But AC core will not accept any custom non-blizzlike changes of course
Original source
But you can always add more hooks if required
rektbyfaith
05-14-2024, 02:37 PM #10Archived author: sudlud • Posted: 2024-05-14T14:37:14.203000+00:00
Original source
But you can always add more hooks if required