[DiscordArchive] So this actually calls „executeHook“ on all the dummy hooks?
[DiscordArchive] So this actually calls „executeHook“ on all the dummy hooks?
Original source
So this actually calls „executeHook“ on all the dummy hooks?
rektbyfaith
04-03-2024, 03:39 PM #1Archived author: sudlud • Posted: 2024-04-03T15:39:27.509000+00:00
Original source
So this actually calls „executeHook“ on all the dummy hooks?
Original source
Yeah. So if you created and registered a player script that implements only OnLogin hook, the core would try to call all other possible hooks for this script, such as OnBeforePlayerUpdate, OnPlayerUpdate, OnIsPvP, etc (but it would execute dummy hooks). And the more scripts you register, the greater the performance impact.
rektbyfaith
04-03-2024, 03:47 PM #2Archived author: walkline • Posted: 2024-04-03T15:47:55.490000+00:00
Original source
Yeah. So if you created and registered a player script that implements only OnLogin hook, the core would try to call all other possible hooks for this script, such as OnBeforePlayerUpdate, OnPlayerUpdate, OnIsPvP, etc (but it would execute dummy hooks). And the more scripts you register, the greater the performance impact.
Original source
Alright, so it always adds a new instance of the script to the list
rektbyfaith
04-03-2024, 03:52 PM #3Archived author: sudlud • Posted: 2024-04-03T15:52:55.021000+00:00
Original source
Alright, so it always adds a new instance of the script to the list
Original source
The player update hooks surely get called often in this case
rektbyfaith
04-03-2024, 03:55 PM #4Archived author: sudlud • Posted: 2024-04-03T15:55:13.196000+00:00
Original source
The player update hooks surely get called often in this case
Original source
![[Image: Screenshot_2024-04-03_at_12.01.28_PM.png...5165c30fb&]](https://cdn.discordapp.com/attachments/284323424032129024/1225112976390885506/Screenshot_2024-04-03_at_12.01.28_PM.png?ex=690c1d9f&is=690acc1f&hm=9ce42ba8e2c2e08fc8f3690db174824827bf0f63ac95cc3e1234ecf5165c30fb&)
rektbyfaith
04-03-2024, 04:01 PM #5Archived author: Natrist • Posted: 2024-04-03T16:01:35.107000+00:00
Original source
Original source
Is anyone even using the player update related hooks
rektbyfaith
04-03-2024, 04:36 PM #6Archived author: sudlud • Posted: 2024-04-03T16:36:22.800000+00:00
Original source
Is anyone even using the player update related hooks
Original source
What if you comment them out maybe they’re responsible for most of it
rektbyfaith
04-03-2024, 04:37 PM #7Archived author: sudlud • Posted: 2024-04-03T16:37:11.102000+00:00
Original source
What if you comment them out maybe they’re responsible for most of it
Original source
It's also a matter of senseless hook implementation
rektbyfaith
04-03-2024, 06:32 PM #8Archived author: Foe • Posted: 2024-04-03T18:32:45.418000+00:00
Original source
It's also a matter of senseless hook implementation
Original source
OnIsPvP as an example
rektbyfaith
04-03-2024, 06:33 PM #9Archived author: Foe • Posted: 2024-04-03T18:33:02.722000+00:00
Original source
OnIsPvP as an example
Original source
No hook should ever be implemented in some bool function that is used everywhere in the core and other scripts for that matter
rektbyfaith
04-03-2024, 06:33 PM #10Archived author: Foe • Posted: 2024-04-03T18:33:31.959000+00:00
Original source
No hook should ever be implemented in some bool function that is used everywhere in the core and other scripts for that matter
1 Guest(s)
1 Guest(s)