[DiscordArchive] Yes <@155500896820789248> ?
[DiscordArchive] Yes <@155500896820789248> ?
Original source
Yes <@155500896820789248> ?
rektbyfaith
02-22-2024, 04:31 PM #1Archived author: Elmsroth • Posted: 2024-02-22T16:31:47.317000+00:00
Original source
Yes <@155500896820789248> ?
Original source
Nice to see ya here :p
rektbyfaith
02-22-2024, 04:31 PM #2Archived author: Elmsroth • Posted: 2024-02-22T16:31:53.789000+00:00
Original source
Nice to see ya here :p
Original source
I believe I fixed the only missing occurence of the replaced member variable from my PR on which you commented earlier.
rektbyfaith
02-22-2024, 04:31 PM #3Archived author: Natrist • Posted: 2024-02-22T16:31:57.900000+00:00
Original source
I believe I fixed the only missing occurence of the replaced member variable from my PR on which you commented earlier.
Original source
Merging it would be a nice quality of life improvement for me, as I'm getting the same error every time I rebase my work branch on the project's master.
rektbyfaith
02-22-2024, 04:32 PM #4Archived author: Natrist • Posted: 2024-02-22T16:32:33.958000+00:00
Original source
Merging it would be a nice quality of life improvement for me, as I'm getting the same error every time I rebase my work branch on the project's master.
Original source
I'll force push in a minute.
rektbyfaith
02-22-2024, 04:32 PM #5Archived author: Natrist • Posted: 2024-02-22T16:32:45.459000+00:00
Original source
I'll force push in a minute.
Original source
Perhaps try to ping a maintainer of the project to quickly merge that.
rektbyfaith
02-22-2024, 04:33 PM #6Archived author: Elmsroth • Posted: 2024-02-22T16:33:03.845000+00:00
Original source
Perhaps try to ping a maintainer of the project to quickly merge that.
Original source
They can take their sweet time.
rektbyfaith
02-22-2024, 04:33 PM #7Archived author: Natrist • Posted: 2024-02-22T16:33:20.809000+00:00
Original source
They can take their sweet time.
Original source
However, I was going to mention that I'm working on many big updates to add compatibility with my WowGM client that I'm going to release soon™.
rektbyfaith
02-22-2024, 04:33 PM #8Archived author: Natrist • Posted: 2024-02-22T16:33:51.165000+00:00
Original source
However, I was going to mention that I'm working on many big updates to add compatibility with my WowGM client that I'm going to release soon™.
Original source
:p
Do you know if there any policy regarding commit squashing in PR ?
I mean I often tries when possible to squash all commits in one to make the commit tree as clean as possible
rektbyfaith
02-22-2024, 04:34 PM #9Archived author: Elmsroth • Posted: 2024-02-22T16:34:09.551000+00:00
Original source
:p
Do you know if there any policy regarding commit squashing in PR ?
I mean I often tries when possible to squash all commits in one to make the commit tree as clean as possible
Original source
It might be worth checking out my changes at https://github.com/azerothcore/azerothco...atrist-dev
rektbyfaith
02-22-2024, 04:34 PM #10Archived author: Natrist • Posted: 2024-02-22T16:34:28.909000+00:00
Original source
It might be worth checking out my changes at https://github.com/azerothcore/azerothco...atrist-dev
1 Guest(s)
1 Guest(s)