[DiscordArchive] where would be good place in core to put custom code(file) so that its accessible in whole core and
[DiscordArchive] where would be good place in core to put custom code(file) so that its accessible in whole core and
Original source
If you need to change how the core works, then a module isn't the solution to begin with
rektbyfaith
01-17-2024, 04:37 PM #11Archived author: Foe • Posted: 2024-01-17T16:37:15.397000+00:00
Original source
If you need to change how the core works, then a module isn't the solution to begin with
Original source
well if it was possible to swap implementation from module i would say it would be fine....there are projects which work like that
rektbyfaith
01-17-2024, 04:38 PM #12Archived author: Rymercyble • Posted: 2024-01-17T16:38:09.855000+00:00
Original source
well if it was possible to swap implementation from module i would say it would be fine....there are projects which work like that
Original source
Just change what you need to change in the core and supply it as a patch ♂️
rektbyfaith
01-17-2024, 04:39 PM #13Archived author: Foe • Posted: 2024-01-17T16:39:16.897000+00:00
Original source
Just change what you need to change in the core and supply it as a patch ♂️
Original source
Exactly. If you need to change how the core works then the changes belong in their own branch. Otherwise, the code base ends up getting convoluted and that’s what we’re seeing right now with AC. The configuration files are also riddled with mostly useless options.
rektbyfaith
01-17-2024, 06:47 PM #14Archived author: Natrist • Posted: 2024-01-17T18:47:23.774000+00:00
Original source
Exactly. If you need to change how the core works then the changes belong in their own branch. Otherwise, the code base ends up getting convoluted and that’s what we’re seeing right now with AC. The configuration files are also riddled with mostly useless options.
Original source
but that still doesnt answer my question <:kek:1065379143887372398>
rektbyfaith
01-17-2024, 06:52 PM #15Archived author: Rymercyble • Posted: 2024-01-17T18:52:31.100000+00:00
Original source
but that still doesnt answer my question <:kek:1065379143887372398>
Original source
Um. Anywhere? For my progression core patch I added a folder `src\server\game\Progression` and added it as a defined instance (whatever the hell it's called) so all I had to do was #include "Progression.h" in any file and I could use sProgression->FunctionNameGoesHere there
rektbyfaith
01-17-2024, 08:22 PM #16Archived author: Revision • Posted: 2024-01-17T20:22:24.424000+00:00
Original source
Um. Anywhere? For my progression core patch I added a folder `src\server\game\Progression` and added it as a defined instance (whatever the hell it's called) so all I had to do was #include "Progression.h" in any file and I could use sProgression->FunctionNameGoesHere there
Original source
i was thinking about that but in this case its general helper functions so game felt weird
rektbyfaith
01-17-2024, 08:24 PM #17Archived author: Rymercyble • Posted: 2024-01-17T20:24:42.429000+00:00
Original source
i was thinking about that but in this case its general helper functions so game felt weird
Original source
It simplifies things, I did it because it allowed me to edit the core but with a whole lot less code because I just called my own functions instead of adding those functions everywhere.
rektbyfaith
01-17-2024, 08:29 PM #18Archived author: Revision • Posted: 2024-01-17T20:29:01.660000+00:00
Original source
It simplifies things, I did it because it allowed me to edit the core but with a whole lot less code because I just called my own functions instead of adding those functions everywhere.