[DiscordArchive] so what ? remove override ?
[DiscordArchive] so what ? remove override ?
Archived author: Natrist • Posted: 2023-12-27T20:32:24.666000+00:00
Original source
I didn’t bother reading everything but the way I see it, any major refactor committed from now on should consist mainly of removed lines. If you are adding thousands of lines to what is already an unmaintainable abomination you’re going to be giving everyone a bad time, including yourself, down the road.
Archived author: Kitzunu • Posted: 2023-12-27T20:32:47.720000+00:00
Original source
just delete win32 folder while you at it
Archived author: Natrist • Posted: 2023-12-27T20:33:07.521000+00:00
Original source
https://tenor.com/view/go-on-gollum-my-p...5161632621
Archived author: Rymercyble • Posted: 2023-12-27T20:35:15.903000+00:00
Original source
that doesnt make any sense u cant universally make such requirement
Archived author: Rymercyble • Posted: 2023-12-27T20:37:45.575000+00:00
Original source
except that lines of code is quite bad metric
Archived author: Natrist • Posted: 2023-12-27T20:38:34.960000+00:00
Original source
Characters count too, but GitHub isn’t taking them into account.
Archived author: Rymercyble • Posted: 2023-12-27T20:39:52.606000+00:00
Original source
thats still bad metric that would just encourage retarded abbreviations
Archived author: Rymercyble • Posted: 2023-12-27T20:41:33.548000+00:00
Original source
which i would say abbreviations are already issue in this project
Archived author: Rymercyble • Posted: 2023-12-27T21:12:48.830000+00:00
Original source
alright i can startup server and some procs work and some dont
Archived author: Rymercyble • Posted: 2023-12-27T21:13:02.836000+00:00
Original source
also stuff like `AuraEffect::HandleProcTriggerSpellAuraProc: Could not trigger spell 0 from aura 44448 proc, because the spell does not have an entry in Spell.dbc.` in console