Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] I added the deprecated attribute (C++14) to the method I am replacing but I figured we might just re

[DiscordArchive] I added the deprecated attribute (C++14) to the method I am replacing but I figured we might just re

[DiscordArchive] I added the deprecated attribute (C++14) to the method I am replacing but I figured we might just re

rektbyfaith
Administrator
0
11-27-2023, 11:15 PM
#1
Archived author: Natrist • Posted: 2023-11-27T23:15:13.843000+00:00
Original source

I added the deprecated attribute (C++14) to the method I am replacing but I figured we might just remove it entirely and update the modules that depend on it. What do you prefer?
rektbyfaith
11-27-2023, 11:15 PM #1

Archived author: Natrist • Posted: 2023-11-27T23:15:13.843000+00:00
Original source

I added the deprecated attribute (C++14) to the method I am replacing but I figured we might just remove it entirely and update the modules that depend on it. What do you prefer?

rektbyfaith
Administrator
0
11-27-2023, 11:15 PM
#2
Archived author: Nyeriah • Posted: 2023-11-27T23:15:54.872000+00:00
Original source

yes, remove it and update the modules that need updating (it seems there's just one of them)
rektbyfaith
11-27-2023, 11:15 PM #2

Archived author: Nyeriah • Posted: 2023-11-27T23:15:54.872000+00:00
Original source

yes, remove it and update the modules that need updating (it seems there's just one of them)

rektbyfaith
Administrator
0
11-27-2023, 11:17 PM
#3
Archived author: Nyeriah • Posted: 2023-11-27T23:17:49.099000+00:00
Original source

the runners run with /wall so even if its just a deprecation warning the builds will fail otherwise
rektbyfaith
11-27-2023, 11:17 PM #3

Archived author: Nyeriah • Posted: 2023-11-27T23:17:49.099000+00:00
Original source

the runners run with /wall so even if its just a deprecation warning the builds will fail otherwise

rektbyfaith
Administrator
0
11-27-2023, 11:17 PM
#4
Archived author: Natrist • Posted: 2023-11-27T23:17:59.373000+00:00
Original source

Yeah, I noticed.
rektbyfaith
11-27-2023, 11:17 PM #4

Archived author: Natrist • Posted: 2023-11-27T23:17:59.373000+00:00
Original source

Yeah, I noticed.

rektbyfaith
Administrator
0
11-27-2023, 11:18 PM
#5
Archived author: Natrist • Posted: 2023-11-27T23:18:37.695000+00:00
Original source

So I'll just remove the function entirely and you can safely ignore the compilation error. I'll send in a PR for the anti-cheat module later tonight.
rektbyfaith
11-27-2023, 11:18 PM #5

Archived author: Natrist • Posted: 2023-11-27T23:18:37.695000+00:00
Original source

So I'll just remove the function entirely and you can safely ignore the compilation error. I'll send in a PR for the anti-cheat module later tonight.

rektbyfaith
Administrator
0
11-27-2023, 11:19 PM
#6
Archived author: Nyeriah • Posted: 2023-11-27T23:19:24.695000+00:00
Original source

cool, thanks a bunch
rektbyfaith
11-27-2023, 11:19 PM #6

Archived author: Nyeriah • Posted: 2023-11-27T23:19:24.695000+00:00
Original source

cool, thanks a bunch

rektbyfaith
Administrator
0
11-28-2023, 01:00 AM
#7
Archived author: Natrist • Posted: 2023-11-28T01:00:23.030000+00:00
Original source

<@251803844307189761> it's done
rektbyfaith
11-28-2023, 01:00 AM #7

Archived author: Natrist • Posted: 2023-11-28T01:00:23.030000+00:00
Original source

<@251803844307189761> it's done

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)