[DiscordArchive] Hi , guys I'm new with all of this and I'm trying to learn by fixing bugs.
[DiscordArchive] Hi , guys I'm new with all of this and I'm trying to learn by fixing bugs.
Original source
Hi , guys I'm new with all of this and I'm trying to learn by fixing bugs.
I got interested in this one https://github.com/azerothcore/azerothco...sues/17800
So far I discovered that when you use "Presence of Mind" it puts infinite cooldown (1 month) on "Arcane power" and when you lose the "Presence of Mind" aura it puts a 1.5 second cooldown on "Arcane power" again to reset the infinite cooldown so the spell can be used again. The problem is when you have the T4 mage set bonus it subtracts flat 24 seconds from that 1.5 seconds and it becomes a negative number, then there is a check in the code if the number is negative make it 0 and if its 0 do not reset any spell category cooldowns. So I made it to reset the cooldowns even if the recovery time is 0. It works but I have no idea what side issues this can cause.
Original code:
https://github.com/azerothcore/azerothco...cpp#L10912
I'm sure this can be fixed with a simple hook but still I'm trying to understand how any of this works.
I think I've read all that is available in AzerothCore docs about spells and how they work.
Do you have any advices for me about this ?
![[Image: image.png?ex=690c18f0&is=690ac770&hm=6a1...2cb666b78&]](https://cdn.discordapp.com/attachments/284323424032129024/1177997526964633700/image.png?ex=690c18f0&is=690ac770&hm=6a1aec142e554668c9c40f576452962e8c03a36bf5c01ac9516c8442cb666b78&)
rektbyfaith
11-25-2023, 03:41 PM #1Archived author: liubcata • Posted: 2023-11-25T15:41:36.532000+00:00
Original source
Hi , guys I'm new with all of this and I'm trying to learn by fixing bugs.
I got interested in this one https://github.com/azerothcore/azerothco...sues/17800
So far I discovered that when you use "Presence of Mind" it puts infinite cooldown (1 month) on "Arcane power" and when you lose the "Presence of Mind" aura it puts a 1.5 second cooldown on "Arcane power" again to reset the infinite cooldown so the spell can be used again. The problem is when you have the T4 mage set bonus it subtracts flat 24 seconds from that 1.5 seconds and it becomes a negative number, then there is a check in the code if the number is negative make it 0 and if its 0 do not reset any spell category cooldowns. So I made it to reset the cooldowns even if the recovery time is 0. It works but I have no idea what side issues this can cause.
Original code:
https://github.com/azerothcore/azerothco...cpp#L10912
I'm sure this can be fixed with a simple hook but still I'm trying to understand how any of this works.
I think I've read all that is available in AzerothCore docs about spells and how they work.
Do you have any advices for me about this ?
Original source
What in God's name is even going on in that function?
rektbyfaith
11-25-2023, 05:12 PM #2Archived author: Natrist • Posted: 2023-11-25T17:12:07.374000+00:00
Original source
What in God's name is even going on in that function?
Original source
Even the function signature is leading me to believe we live in a simulation:
`void Player::AddSpellAndCategoryCooldowns(SpellInfo const* spellInfo, uint32 itemId, Spell* spell, bool infinityCooldown)`
rektbyfaith
11-25-2023, 05:13 PM #3Archived author: Natrist • Posted: 2023-11-25T17:13:25.353000+00:00
Original source
Even the function signature is leading me to believe we live in a simulation:
`void Player::AddSpellAndCategoryCooldowns(SpellInfo const* spellInfo, uint32 itemId, Spell* spell, bool infinityCooldown)`
Original source
Also, the rec prefix/suffix in WoW context stands for record, as in DBClient record.
rektbyfaith
11-25-2023, 05:35 PM #4Archived author: Natrist • Posted: 2023-11-25T17:35:56.895000+00:00
Original source
Also, the rec prefix/suffix in WoW context stands for record, as in DBClient record.
Original source
The variable names in that function are a little confusing to begin with.
rektbyfaith
11-25-2023, 05:36 PM #5Archived author: Natrist • Posted: 2023-11-25T17:36:29.349000+00:00
Original source
The variable names in that function are a little confusing to begin with.
Original source
category recovery
rektbyfaith
11-25-2023, 05:37 PM #6Archived author: brotalnia • Posted: 2023-11-25T17:37:04.794000+00:00
Original source
category recovery
Original source
catrec
rektbyfaith
11-25-2023, 05:37 PM #7Archived author: brotalnia • Posted: 2023-11-25T17:37:10.257000+00:00
Original source
catrec
Original source
personally im so not fan of abbreviation i never understood why any1 write "cat" instead of category i guess maybe to make it harder for new ppl
rektbyfaith
11-25-2023, 05:39 PM #8Archived author: Rymercyble • Posted: 2023-11-25T17:39:10.419000+00:00
Original source
personally im so not fan of abbreviation i never understood why any1 write "cat" instead of category i guess maybe to make it harder for new ppl
Original source
Same
rektbyfaith
11-25-2023, 05:39 PM #9Archived author: Natrist • Posted: 2023-11-25T17:39:19.146000+00:00
Original source
Same
Original source
If you can’t guess what the code does at first glance it’s bad code.
rektbyfaith
11-25-2023, 05:39 PM #10Archived author: Natrist • Posted: 2023-11-25T17:39:32.477000+00:00
Original source
If you can’t guess what the code does at first glance it’s bad code.