Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] i have a PR I'm working on that depends on another PR. is it a good idea to per-merge that branch in

[DiscordArchive] i have a PR I'm working on that depends on another PR. is it a good idea to per-merge that branch in

[DiscordArchive] i have a PR I'm working on that depends on another PR. is it a good idea to per-merge that branch in

rektbyfaith
Administrator
0
11-06-2023, 10:10 PM
#1
Archived author: KJack • Posted: 2023-11-06T22:10:30.400000+00:00
Original source

i have a PR I'm working on that depends on another PR. is it a good idea to per-merge that branch into my PR branch to ensure that testers have all the changes they need to test with?
rektbyfaith
11-06-2023, 10:10 PM #1

Archived author: KJack • Posted: 2023-11-06T22:10:30.400000+00:00
Original source

i have a PR I'm working on that depends on another PR. is it a good idea to per-merge that branch into my PR branch to ensure that testers have all the changes they need to test with?

rektbyfaith
Administrator
0
11-06-2023, 10:11 PM
#2
Archived author: Frost® • Posted: 2023-11-06T22:11:30.322000+00:00
Original source

i have merged newest prs and now have double spawns of Doodad_icecrown_elevator01 after Dreamwalker and worlserver crashes after people reaches elevator
rektbyfaith
11-06-2023, 10:11 PM #2

Archived author: Frost® • Posted: 2023-11-06T22:11:30.322000+00:00
Original source

i have merged newest prs and now have double spawns of Doodad_icecrown_elevator01 after Dreamwalker and worlserver crashes after people reaches elevator

rektbyfaith
Administrator
0
11-06-2023, 10:11 PM
#3
Archived author: Frost® • Posted: 2023-11-06T22:11:55.056000+00:00
Original source

i have no idea whats happening XD
rektbyfaith
11-06-2023, 10:11 PM #3

Archived author: Frost® • Posted: 2023-11-06T22:11:55.056000+00:00
Original source

i have no idea whats happening XD

rektbyfaith
Administrator
0
11-06-2023, 11:11 PM
#4
Archived author: KJack • Posted: 2023-11-06T23:11:44.356000+00:00
Original source

Going with just calling out the requirements in the PR text for now, but integrating them myself would make testing easier. Let me know if that's acceptable.
rektbyfaith
11-06-2023, 11:11 PM #4

Archived author: KJack • Posted: 2023-11-06T23:11:44.356000+00:00
Original source

Going with just calling out the requirements in the PR text for now, but integrating them myself would make testing easier. Let me know if that's acceptable.

Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)