[DiscordArchive] you interested in refactors for stuff like that or let sleeping dogs lie?
[DiscordArchive] you interested in refactors for stuff like that or let sleeping dogs lie?
Original source
Why not
rektbyfaith
10-29-2023, 10:20 PM #11Archived author: Kitzunu • Posted: 2023-10-29T22:20:56.307000+00:00
Original source
Why not
Original source
nice, let me add it to the list
rektbyfaith
10-29-2023, 10:21 PM #12Archived author: KJack • Posted: 2023-10-29T22:21:04.794000+00:00
Original source
nice, let me add it to the list
Original source
i see what's happening but i don't know how to fix it yet. when i add the immunities first, i can then remove them.
```c++
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_FREEZE, true, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_SNARE, true, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_ROOT, true, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_FREEZE, false, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_SNARE, false, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_ROOT, false, SPELL_BLOCK_TYPE_ALL, true);
```
```
----------------------------------------
Unit::ApplySpellImmune: 0 5 13 true
----------------------------------------
Unit::ApplySpellImmune: 0 5 11 true
----------------------------------------
Unit::ApplySpellImmune: 0 5 7 true
----------------------------------------
Unit::ApplySpellImmune: 0 5 13 false
Unit::ApplySpellImmune: apply = false
Unit::ApplySpellImmune: Current immunities for op 5:
Unit::ApplySpellImmune: 0 13 0
Unit::ApplySpellImmune: 0 11 0
Unit::ApplySpellImmune: 0 7 0
Should 0 (type 13) be removed?
Yes!
----------------------------------------
Unit::ApplySpellImmune: 0 5 11 false
Unit::ApplySpellImmune: apply = false
Unit::ApplySpellImmune: Current immunities for op 5:
Unit::ApplySpellImmune: 0 11 0
Unit::ApplySpellImmune: 0 7 0
Should 0 (type 11) be removed?
Yes!
----------------------------------------
Unit::ApplySpellImmune: 0 5 7 false
Unit::ApplySpellImmune: apply = false
Unit::ApplySpellImmune: Current immunities for op 5:
Unit::ApplySpellImmune: 0 7 0
Should 0 (type 7) be removed?
Yes!
```
rektbyfaith
10-29-2023, 10:37 PM #13Archived author: KJack • Posted: 2023-10-29T22:37:35.780000+00:00
Original source
i see what's happening but i don't know how to fix it yet. when i add the immunities first, i can then remove them.
```c++
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_FREEZE, true, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_SNARE, true, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_ROOT, true, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_FREEZE, false, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_SNARE, false, SPELL_BLOCK_TYPE_ALL, true);
me->ApplySpellImmune(0, IMMUNITY_MECHANIC, MECHANIC_ROOT, false, SPELL_BLOCK_TYPE_ALL, true);
```
```
----------------------------------------
Unit::ApplySpellImmune: 0 5 13 true
----------------------------------------
Unit::ApplySpellImmune: 0 5 11 true
----------------------------------------
Unit::ApplySpellImmune: 0 5 7 true
----------------------------------------
Unit::ApplySpellImmune: 0 5 13 false
Unit::ApplySpellImmune: apply = false
Unit::ApplySpellImmune: Current immunities for op 5:
Unit::ApplySpellImmune: 0 13 0
Unit::ApplySpellImmune: 0 11 0
Unit::ApplySpellImmune: 0 7 0
Should 0 (type 13) be removed?
Yes!
----------------------------------------
Unit::ApplySpellImmune: 0 5 11 false
Unit::ApplySpellImmune: apply = false
Unit::ApplySpellImmune: Current immunities for op 5:
Unit::ApplySpellImmune: 0 11 0
Unit::ApplySpellImmune: 0 7 0
Should 0 (type 11) be removed?
Yes!
----------------------------------------
Unit::ApplySpellImmune: 0 5 7 false
Unit::ApplySpellImmune: apply = false
Unit::ApplySpellImmune: Current immunities for op 5:
Unit::ApplySpellImmune: 0 7 0
Should 0 (type 7) be removed?
Yes!
```
Original source
still has no effect on the actual immunities of the creature in-game
rektbyfaith
10-29-2023, 10:38 PM #14Archived author: KJack • Posted: 2023-10-29T22:38:02.365000+00:00
Original source
still has no effect on the actual immunities of the creature in-game
Original source
so i think that list that is being manipulated is detached from whatever the DB is loading into and whatever the game is reading from
rektbyfaith
10-29-2023, 10:38 PM #15Archived author: KJack • Posted: 2023-10-29T22:38:35.060000+00:00
Original source
so i think that list that is being manipulated is detached from whatever the DB is loading into and whatever the game is reading from
Original source
let me see if i can just straight up add a new immunity
rektbyfaith
10-29-2023, 10:38 PM #16Archived author: KJack • Posted: 2023-10-29T22:38:51.690000+00:00
Original source
let me see if i can just straight up add a new immunity
Original source
( ignore that last `true` in my example functions, i added a `log` bool for testing)
rektbyfaith
10-29-2023, 10:39 PM #17Archived author: KJack • Posted: 2023-10-29T22:39:38.389000+00:00
Original source
( ignore that last `true` in my example functions, i added a `log` bool for testing)
Original source
Just check where we load creature immunities. Perhaps it is seperate
rektbyfaith
10-29-2023, 10:42 PM #18Archived author: Kitzunu • Posted: 2023-10-29T22:42:57.103000+00:00
Original source
Just check where we load creature immunities. Perhaps it is seperate
Original source
I cant recall
rektbyfaith
10-29-2023, 10:43 PM #19Archived author: Kitzunu • Posted: 2023-10-29T22:43:00.070000+00:00
Original source
I cant recall
Original source
will do. i'm going to have to step away for a bit but i'll dig into this tonight. see what's going on.
~~~it doesn't appear i can add mechanic immunities with that function either.~~ nevermind, they just don't show in `.npc info`
rektbyfaith
10-29-2023, 10:44 PM #20Archived author: KJack • Posted: 2023-10-29T22:44:17.605000+00:00
Original source
will do. i'm going to have to step away for a bit but i'll dig into this tonight. see what's going on.
~~~it doesn't appear i can add mechanic immunities with that function either.~~ nevermind, they just don't show in `.npc info`