Forums WoW Modding Support Archives Azerothcore Discord Archives [DiscordArchive] I am sick as fuck, but which PR is yours?

[DiscordArchive] I am sick as fuck, but which PR is yours?

[DiscordArchive] I am sick as fuck, but which PR is yours?

Pages (8): Previous 1 2 3 4 5 6 8 Next  
rektbyfaith
Administrator
0
10-18-2023, 12:26 PM
#31
Archived author: Natrist • Posted: 2023-10-18T12:26:35.844000+00:00
Original source

LOG_DEBUG("network", "WORLD: Received CMSG_WORLD_TELEPORT");
rektbyfaith
10-18-2023, 12:26 PM #31

Archived author: Natrist • Posted: 2023-10-18T12:26:35.844000+00:00
Original source

LOG_DEBUG("network", "WORLD: Received CMSG_WORLD_TELEPORT");

rektbyfaith
Administrator
0
10-18-2023, 12:28 PM
#32
Archived author: Natrist • Posted: 2023-10-18T12:28:38.396000+00:00
Original source

you have hundreds of lines like this when you could remove them all and put something like: LOG_DEBUG("network", "WORLD: Received %s from account %d", opcode->getName(), GetAccountId());
under Opcodes.cpp: 34 and Opcodes.cpp: 47
rektbyfaith
10-18-2023, 12:28 PM #32

Archived author: Natrist • Posted: 2023-10-18T12:28:38.396000+00:00
Original source

you have hundreds of lines like this when you could remove them all and put something like: LOG_DEBUG("network", "WORLD: Received %s from account %d", opcode->getName(), GetAccountId());
under Opcodes.cpp: 34 and Opcodes.cpp: 47

rektbyfaith
Administrator
0
10-18-2023, 12:29 PM
#33
Archived author: Natrist • Posted: 2023-10-18T12:29:33.583000+00:00
Original source


[Image: image.png?ex=690bebed&is=690a9a6d&hm=95a...daa878c9f&]
rektbyfaith
10-18-2023, 12:29 PM #33

Archived author: Natrist • Posted: 2023-10-18T12:29:33.583000+00:00
Original source


[Image: image.png?ex=690bebed&is=690a9a6d&hm=95a...daa878c9f&]

rektbyfaith
Administrator
0
10-18-2023, 12:32 PM
#34
Archived author: Kitzunu • Posted: 2023-10-18T12:32:24.480000+00:00
Original source

So do it?
rektbyfaith
10-18-2023, 12:32 PM #34

Archived author: Kitzunu • Posted: 2023-10-18T12:32:24.480000+00:00
Original source

So do it?

rektbyfaith
Administrator
0
10-18-2023, 12:32 PM
#35
Archived author: Natrist • Posted: 2023-10-18T12:32:39.861000+00:00
Original source

sure but I figured that should be in a different PR xD
rektbyfaith
10-18-2023, 12:32 PM #35

Archived author: Natrist • Posted: 2023-10-18T12:32:39.861000+00:00
Original source

sure but I figured that should be in a different PR xD

rektbyfaith
Administrator
0
10-18-2023, 12:33 PM
#36
Archived author: Bench • Posted: 2023-10-18T12:33:21.639000+00:00
Original source

Are you certain the worldport command doesn't take commas though? Because there are a whole bunch of worldport macros in old PTR clients with commas placed in em. Doesn't make any sense to me for most of those macros to be made intentionally not working like that
rektbyfaith
10-18-2023, 12:33 PM #36

Archived author: Bench • Posted: 2023-10-18T12:33:21.639000+00:00
Original source

Are you certain the worldport command doesn't take commas though? Because there are a whole bunch of worldport macros in old PTR clients with commas placed in em. Doesn't make any sense to me for most of those macros to be made intentionally not working like that

rektbyfaith
Administrator
0
10-18-2023, 12:34 PM
#37
Archived author: Natrist • Posted: 2023-10-18T12:34:15.439000+00:00
Original source

strcpy(whitespace, "\t\r\n\" ");
rektbyfaith
10-18-2023, 12:34 PM #37

Archived author: Natrist • Posted: 2023-10-18T12:34:15.439000+00:00
Original source

strcpy(whitespace, "\t\r\n\" ");

rektbyfaith
Administrator
0
10-18-2023, 12:34 PM
#38
Archived author: Kitzunu • Posted: 2023-10-18T12:34:27.449000+00:00
Original source

yea obv
rektbyfaith
10-18-2023, 12:34 PM #38

Archived author: Kitzunu • Posted: 2023-10-18T12:34:27.449000+00:00
Original source

yea obv

rektbyfaith
Administrator
0
10-18-2023, 12:34 PM
#39
Archived author: Natrist • Posted: 2023-10-18T12:34:31.151000+00:00
Original source

this is the token whitespace the client looks for while creating tokens from the arguments
rektbyfaith
10-18-2023, 12:34 PM #39

Archived author: Natrist • Posted: 2023-10-18T12:34:31.151000+00:00
Original source

this is the token whitespace the client looks for while creating tokens from the arguments

rektbyfaith
Administrator
0
10-18-2023, 12:34 PM
#40
Archived author: Natrist • Posted: 2023-10-18T12:34:41.971000+00:00
Original source

as you can see, there is no commas
rektbyfaith
10-18-2023, 12:34 PM #40

Archived author: Natrist • Posted: 2023-10-18T12:34:41.971000+00:00
Original source

as you can see, there is no commas

Pages (8): Previous 1 2 3 4 5 6 8 Next  
Recently Browsing
 1 Guest(s)
Recently Browsing
 1 Guest(s)