[DiscordArchive] I am sick as fuck, but which PR is yours?
[DiscordArchive] I am sick as fuck, but which PR is yours?
Original source
LOG_DEBUG("network", "WORLD: Received CMSG_WORLD_TELEPORT");
rektbyfaith
10-18-2023, 12:26 PM #31Archived author: Natrist • Posted: 2023-10-18T12:26:35.844000+00:00
Original source
LOG_DEBUG("network", "WORLD: Received CMSG_WORLD_TELEPORT");
Original source
you have hundreds of lines like this when you could remove them all and put something like: LOG_DEBUG("network", "WORLD: Received %s from account %d", opcode->getName(), GetAccountId());
under Opcodes.cpp: 34 and Opcodes.cpp: 47
rektbyfaith
10-18-2023, 12:28 PM #32Archived author: Natrist • Posted: 2023-10-18T12:28:38.396000+00:00
Original source
you have hundreds of lines like this when you could remove them all and put something like: LOG_DEBUG("network", "WORLD: Received %s from account %d", opcode->getName(), GetAccountId());
under Opcodes.cpp: 34 and Opcodes.cpp: 47
Original source
![[Image: image.png?ex=690bebed&is=690a9a6d&hm=95a...daa878c9f&]](https://cdn.discordapp.com/attachments/284323424032129024/1164178456997793823/image.png?ex=690bebed&is=690a9a6d&hm=95a1505593bfe60a2db1152d12632f333a948634d9926d244d79f08daa878c9f&)
rektbyfaith
10-18-2023, 12:29 PM #33Archived author: Natrist • Posted: 2023-10-18T12:29:33.583000+00:00
Original source
Original source
So do it?
rektbyfaith
10-18-2023, 12:32 PM #34Archived author: Kitzunu • Posted: 2023-10-18T12:32:24.480000+00:00
Original source
So do it?
Original source
sure but I figured that should be in a different PR xD
rektbyfaith
10-18-2023, 12:32 PM #35Archived author: Natrist • Posted: 2023-10-18T12:32:39.861000+00:00
Original source
sure but I figured that should be in a different PR xD
Original source
Are you certain the worldport command doesn't take commas though? Because there are a whole bunch of worldport macros in old PTR clients with commas placed in em. Doesn't make any sense to me for most of those macros to be made intentionally not working like that
rektbyfaith
10-18-2023, 12:33 PM #36Archived author: Bench • Posted: 2023-10-18T12:33:21.639000+00:00
Original source
Are you certain the worldport command doesn't take commas though? Because there are a whole bunch of worldport macros in old PTR clients with commas placed in em. Doesn't make any sense to me for most of those macros to be made intentionally not working like that
Original source
strcpy(whitespace, "\t\r\n\" ");
rektbyfaith
10-18-2023, 12:34 PM #37Archived author: Natrist • Posted: 2023-10-18T12:34:15.439000+00:00
Original source
strcpy(whitespace, "\t\r\n\" ");
Original source
yea obv
rektbyfaith
10-18-2023, 12:34 PM #38Archived author: Kitzunu • Posted: 2023-10-18T12:34:27.449000+00:00
Original source
yea obv
Original source
this is the token whitespace the client looks for while creating tokens from the arguments
rektbyfaith
10-18-2023, 12:34 PM #39Archived author: Natrist • Posted: 2023-10-18T12:34:31.151000+00:00
Original source
this is the token whitespace the client looks for while creating tokens from the arguments
Original source
as you can see, there is no commas
rektbyfaith
10-18-2023, 12:34 PM #40Archived author: Natrist • Posted: 2023-10-18T12:34:41.971000+00:00
Original source
as you can see, there is no commas